Java API client sample for TaskQueue API

Yanivi had pushed this and hence closing.

[yanivi, 2011-05-04 19:32:16]

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/pom.xml
File taskqueue-json-oauth-sample/pom.xml (right):

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/pom....
taskqueue-json-oauth-sample/pom.xml:1: <project
xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
missing .project and .classpath files; please take a look at the other samples,
which you can probably directly copy, except changing the project name in
.project

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
File
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/Auth.java
(right):

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/Auth.java:61:
File file = new File(TOKEN_FILE);
Our security best practices say that you should not store sensitive user data
like OAuth credentials in plaintext.  So far we've decided not to store them
until we've got a review from the security team.  But if you still want to do
it, please just put a comment explain why this is insecure, and that a real
application should try to do better.

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/Auth.java:165:
tokenSecret = dis.readLine();
readLine is deprecated.  according to the deprecation message, better to use
BufferedReader.readLine()

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
File
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/TaskQueuePuller.java
(right):

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/TaskQueuePuller.java:128:
private static void getTask() throws IOException {
unused

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
File
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/TaskQueueSample.java
(right):

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/TaskQueueSample.java:27:
* Sample which leases task from TaskQueueService, performs work on the paylaod
payload

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/TaskQueueSample.java:68:
* For illustration purose, we are first getting the stats of the specified
puposes

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/TaskQueueSample.java:69:
* queue followed by leasing tasks and deleting them. Users cna change the
Users can

[vibhooti, 2011-05-04 20:41:04]

Incorporated comments. Kindly review.

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/pom.xml
File taskqueue-json-oauth-sample/pom.xml (right):

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/pom....
taskqueue-json-oauth-sample/pom.xml:1: <project
xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
Added

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
File
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/Auth.java
(right):

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/Auth.java:61:
File file = new File(TOKEN_FILE);
Made a note of it. We will do better in next patch.

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/Auth.java:165:
tokenSecret = dis.readLine();
On 2011/05/04 19:32:16, yanivi wrote:
> readLine is deprecated.  according to the deprecation message, better to use
> BufferedReader.readLine()

Done.

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
File
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/TaskQueuePuller.java
(right):

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/TaskQueuePuller.java:128:
private static void getTask() throws IOException {
Yes, Lot of functions are unused but provided so that it is easy for user to use
them if needed. For example purpose, we are just showing lease and delete of
tasks.

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
File
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/TaskQueueSample.java
(right):

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/TaskQueueSample.java:27:
* Sample which leases task from TaskQueueService, performs work on the paylaod
On 2011/05/04 19:32:16, yanivi wrote:
> payload

Done.

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/TaskQueueSample.java:68:
* For illustration purose, we are first getting the stats of the specified
On 2011/05/04 19:32:16, yanivi wrote:
> puposes

Done.

http://codereview.appspot.com/4466042/diff/1/taskqueue-json-oauth-sample/src/...
taskqueue-json-oauth-sample/src/com/google/cloud/taskqueue/client/sample/TaskQueueSample.java:69:
* queue followed by leasing tasks and deleting them. Users cna change the
On 2011/05/04 19:32:16, yanivi wrote:
> Users can

Done.

[yanivi, 2011-05-04 20:46:58]

LGTM

[aiuto, 2011-06-24 02:38:01]

On 2011/05/04 20:46:58, yanivi wrote:
> LGTM

Vibhooti: Did you hg push this?  If so, can you edit the issue to marked it
closed.

[aiuto, 2011-07-14 16:11:27]

On 2011/06/24 02:38:01, aiuto wrote:
> On 2011/05/04 20:46:58, yanivi wrote:
> > LGTM
> 
> Vibhooti: Did you hg push this?  If so, can you edit the issue to marked it
> closed.

Ping again.
If this is pushed, can you close it out.