code review 4452056: cgi: export RequestFromMap

cgi: export RequestFromMap

[eds, 2011-04-28 19:20:51]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-04-28 19:23:04]

http://codereview.appspot.com/4452056/diff/4001/src/pkg/http/cgi/child.go
File src/pkg/http/cgi/child.go (left):

http://codereview.appspot.com/4452056/diff/4001/src/pkg/http/cgi/child.go#old...
src/pkg/http/cgi/child.go:176: func (r *response) UsingTLS() bool {
Where did this go?

[eds, 2011-04-28 19:24:07]

Anticipating questions about not always using HTTP 1.0 for cgi: I
think it's okay to do this. The RFC says applications can check
SERVER_PROTOCOL for feature support and it wouldn't say that if
SERVER_PROTOCOL was always HTTP/1.0. Other CGI libraries I've looked
at don't switch to HTTP/1.0 either.

Either way, the host side should definitely be setting that
environment variable.

- Evan

[eds, 2011-04-28 19:24:50]

On Fri, Apr 29, 2011 at 7:23 AM,  <rsc@golang.org> wrote:
>
http://codereview.appspot.com/4452056/diff/4001/src/pkg/http/cgi/child.go#old...
> src/pkg/http/cgi/child.go:176: func (r *response) UsingTLS() bool {
> Where did this go?

Oh, I just noticed it was still there even though this method isn't a
part of http.ResponseWriter anymore. I can't see any reason to keep it
around.

- Evan

[rsc, 2011-04-28 19:32:01]

Maybe it's fine to drop or maybe we should fill in Request.TLS with
dummy parameters?

[bradfitzgoog, 2011-04-28 20:22:03]

[+agl]

On Thu, Apr 28, 2011 at 12:31 PM, Russ Cox <rsc@golang.org> wrote:

> Maybe it's fine to drop or maybe we should fill in Request.TLS with
> dummy parameters?
>

Not dummy parameters, just incomplete parameters.

This seems like a fine *tls.ConnectionState:

   &tls.ConnectionState{HandshakeComplete: true}

Adam, this is for CGI processes (e.g. running under Apache or somebody who
sets environment variable HTTPS == "ON").  We'd like to tell Go handlers
running in such environments that https is in use, but we don't know the
exact details.

You fine with that ConnectionState?

[bradfitz, 2011-04-28 20:26:31]

LGTM

[bradfitz, 2011-04-28 20:31:01]

*** Submitted as http://code.google.com/p/go/source/detail?r=d93b5329ae9f ***

cgi: export RequestFromMap

R=rsc, bradfitz
CC=golang-dev
http://codereview.appspot.com/4452056

Committer: Brad Fitzpatrick <bradfitz@golang.org>

[agl1, 2011-04-28 20:33:57]

On Thu, Apr 28, 2011 at 4:22 PM, Brad Fitzpatrick <bradfitz@google.com> wrote:
> You fine with that ConnectionState?

Sure, no problem here.


AGL