Issue 4452046: code review 4452046: runtime: turn "too many EPIPE" into real SIGPIPE

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4452046: code review 4452046: runtime: turn "too many EPIPE" into real SIGPIPE (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by rsc

Modified:
13 years, 11 months ago

Reviewers:

CC:
r, iant, golang-dev

Visibility:
Public.

Description

runtime: turn "too many EPIPE" into real SIGPIPE Tested on Linux and OS X, amd64 and 386.

Patch Set 1 #

Patch Set 2 : diff -r 49e59f186834 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 49e59f186834 https://go.googlecode.com/hg #

Patch Set 4 : diff -r 3c60a27e84c5 https://go.googlecode.com/hg #

Patch Set 5 : diff -r 3c60a27e84c5 https://go.googlecode.com/hg #

Patch Set 6 : diff -r 3c60a27e84c5 https://go.googlecode.com/hg #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+142 lines, -1 line)			Patch
M	src/pkg/os/file_posix.go	View	1 2 3 4 5	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/pkg/runtime/darwin/386/signal.c	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/darwin/386/sys.s	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/darwin/amd64/signal.c	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/darwin/amd64/sys.s	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/darwin/os.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/freebsd/386/signal.c	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/freebsd/386/sys.s	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/freebsd/amd64/signal.c	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/freebsd/amd64/sys.s	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/freebsd/os.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/linux/386/signal.c	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/linux/386/sys.s	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/linux/amd64/signal.c	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/linux/amd64/sys.s	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/linux/arm/signal.c	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/linux/arm/sys.s	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/linux/os.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/plan9/thread.c	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/windows/thread.c	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 11 months ago (2011-04-25 20:34:09 UTC) #1

rsc

13 years, 11 months ago (2011-04-25 20:58:12 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=e03d6f3f4c94 ***

runtime: turn "too many EPIPE" into real SIGPIPE

Tested on Linux and OS X, amd64 and 386.

R=r, iant
CC=golang-dev
http://codereview.appspot.com/4452046

Expand All Messages | Collapse All Messages