Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 445042: code review 445042: hash/crc64: new package implementing 64-bit CRC (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by rsc
Modified:
4 years, 1 month ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

hash/crc64: new package implementing 64-bit CRC
hash/crc32: add Update function
hash: add Sum64 interface

Patch Set 1 #

Patch Set 2 : code review 445042: hash/crc64: new package implementing 64-bit CRC #

Patch Set 3 : code review 445042: hash/crc64: new package implementing 64-bit CRC #

Patch Set 4 : code review 445042: hash/crc64: new package implementing 64-bit CRC #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -122 lines) Patch
M src/pkg/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/hash/crc32/crc32.go View 1 chunk +7 lines, -2 lines 0 comments Download
M src/pkg/hash/crc32/crc32_test.go View 1 chunk +33 lines, -33 lines 0 comments Download
M src/pkg/hash/crc64/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/hash/crc64/crc64.go View 1 2 chunks +35 lines, -45 lines 0 comments Download
M src/pkg/hash/crc64/crc64_test.go View 1 2 1 chunk +42 lines, -40 lines 0 comments Download
M src/pkg/hash/hash.go View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
4 years, 1 month ago #1
r2
LGTM On Mar 12, 2010, at 4:17 PM, rsc@golang.org wrote: > Reviewers: r, > > ...
4 years, 1 month ago #2
rsc
4 years, 1 month ago #3
*** Submitted as http://code.google.com/p/go/source/detail?r=93a1ecfbbd68 ***

hash/crc64: new package implementing 64-bit CRC
hash/crc32: add Update function
hash: add Sum64 interface

R=r
CC=golang-dev
http://codereview.appspot.com/445042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5