Transform externs and better compile mode names

Externs are now meaningful JS statements for the compiler.
Clarify compile mode names, ie: run-time can be performed on build time.

[mhermanto, 2011-04-21 22:32:06]

Update patch

[johnfargo, 2011-04-21 23:18:12]

http://codereview.appspot.com/4449043/diff/2001/java/gadgets/src/test/java/or...
File
java/gadgets/src/test/java/org/apache/shindig/gadgets/js/CompilationProcessorTest.java
(right):

http://codereview.appspot.com/4449043/diff/2001/java/gadgets/src/test/java/or...
java/gadgets/src/test/java/org/apache/shindig/gadgets/js/CompilationProcessorTest.java:71:
isA(String.class))).andReturn(outputResponse);
why not test w/ actual values eg "var extern3;" et al?

[johnfargo, 2011-04-21 23:18:21]

LGTM

..beyond that.

On 2011/04/21 23:18:12, johnfargo wrote:
>
http://codereview.appspot.com/4449043/diff/2001/java/gadgets/src/test/java/or...
> File
>
java/gadgets/src/test/java/org/apache/shindig/gadgets/js/CompilationProcessorTest.java
> (right):
> 
>
http://codereview.appspot.com/4449043/diff/2001/java/gadgets/src/test/java/or...
>
java/gadgets/src/test/java/org/apache/shindig/gadgets/js/CompilationProcessorTest.java:71:
> isA(String.class))).andReturn(outputResponse);
> why not test w/ actual values eg "var extern3;" et al?

[mhermanto, 2011-04-21 23:25:13]

On Thu, Apr 21, 2011 at 4:18 PM, <johnfargo@gmail.com> wrote:

> LGTM
>
> ..beyond that.
>
>
> On 2011/04/21 23:18:12, johnfargo wrote:
>
>
>
http://codereview.appspot.com/4449043/diff/2001/java/gadgets/src/test/java/or...
>
>> File
>>
>
>
>
java/gadgets/src/test/java/org/apache/shindig/gadgets/js/CompilationProcessorTest.java
>
>> (right):
>>
>
>
>
>
http://codereview.appspot.com/4449043/diff/2001/java/gadgets/src/test/java/or...
>
>
>
java/gadgets/src/test/java/org/apache/shindig/gadgets/js/CompilationProcessorTest.java:71:
>
>> isA(String.class))).andReturn(outputResponse);
>> why not test w/ actual values eg "var extern3;" et al?
>>
>
Didn't want to couple logic of builder with this unit test.

I've created a new JsResponseBuilderTest that test just externs.

>
>
>
> http://codereview.appspot.com/4449043/
>

[mhermanto, 2011-04-21 23:25:33]

Update patch

[johnfargo, 2011-04-21 23:27:53]

LGTM++

On 2011/04/21 23:25:33, mhermanto wrote:
> Update patch