Issue 4446053: code review 4446053: tutorial: modernize the definition and use of Open.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4446053: code review 4446053: tutorial: modernize the definition and use of Open. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by r

Modified:
13 years, 11 months ago

Reviewers:
rsc

CC:
golang-dev, iant

Visibility:
Public.

Description

tutorial: modernize the definition and use of Open.

Patch Set 1 #

Patch Set 2 : diff -r e97367507c63 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r fb36bd46b1fb https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -51 lines)			Patch
M	doc/go_tutorial.html	View		7 chunks	+71 lines, -42 lines	0 comments	Download
M	doc/go_tutorial.txt	View		3 chunks	+19 lines, -5 lines	0 comments	Download
M	doc/progs/cat.go	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	doc/progs/cat_rot13.go	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	doc/progs/file.go	View		2 chunks	+16 lines, -1 line	0 comments	Download
M	doc/progs/helloworld3.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-04-18 17:26:54 UTC) #1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 11 months ago (2011-04-18 17:36:36 UTC) #2

*** Submitted as http://code.google.com/p/go/source/detail?r=5db1e9aa3041 *** tutorial: modernize the definition and use of Open. R=golang-dev, iant ...

13 years, 11 months ago (2011-04-18 17:51:44 UTC) #4

LGTM

Expand All Messages | Collapse All Messages