Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(55)

Issue 4444086: Expand externs as needed. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by mhermanto
Modified:
14 years, 10 months ago
Reviewers:
johnfargo, fargo
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk
Visibility:
Public.

Description

Otherwise, the initial namespace will not be considered declared and the compiler will be unhappy.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update patch #

Patch Set 3 : Addressing John's comments (retry!) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -17 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsResponseBuilder.java View 1 2 7 chunks +42 lines, -13 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/js/JsResponseBuilderTest.java View 1 1 chunk +14 lines, -4 lines 0 comments Download

Messages

Total messages: 6
mhermanto
14 years, 10 months ago (2011-05-03 01:40:52 UTC) #1
mhermanto
Update patch
14 years, 10 months ago (2011-05-03 01:49:47 UTC) #2
johnfargo
http://codereview.appspot.com/4444086/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsResponseBuilder.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsResponseBuilder.java (right): http://codereview.appspot.com/4444086/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsResponseBuilder.java#newcode242 java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsResponseBuilder.java:242: if (exp.indexOf(".") <= 0) builder.append("var "); why include the ...
14 years, 10 months ago (2011-05-03 01:50:17 UTC) #3
mhermanto
Snapshot re-uploaded. On Mon, May 2, 2011 at 6:50 PM, <johnfargo@gmail.com> wrote: > > > ...
14 years, 10 months ago (2011-05-03 02:01:35 UTC) #4
mhermanto
Addressing John's comments (retry!)
14 years, 10 months ago (2011-05-03 02:07:11 UTC) #5
johnfargo
14 years, 10 months ago (2011-05-03 02:20:05 UTC) #6
LGTM

(still :))

On Mon, May 2, 2011 at 7:07 PM, <mhermanto@gmail.com> wrote:

> Addressing John's comments (retry!)
>
>
> http://codereview.appspot.com/4444086/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b