Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(48)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Unified Diff: test/fixedbugs/bug324.dir/p.go
Issue
4442071
:
code review 4442071: gc: correct handling of unexported method names in embe... (Closed)
Patch Set: diff -r bc9e9e3e43e2 https://go.googlecode.com/hg/
Created 13 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
src/cmd/gc/go.h
src/cmd/gc/go.y
src/cmd/gc/reflect.c
src/cmd/gc/subr.c
src/pkg/go/types/gcimporter.go
src/pkg/reflect/all_test.go
src/pkg/reflect/type.go
src/pkg/runtime/iface.c
test/fixedbugs/bug324.go
test/fixedbugs/bug324.dir/main.go
test/fixedbugs/bug324.dir/p.go
test/golden.out
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« test/fixedbugs/bug324.dir/main.go
('k') |
test/golden.out »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: test/fixedbugs/bug324.dir/p.go
===================================================================
rename from test/bugs/bug324.dir/p.go
rename to test/fixedbugs/bug324.dir/p.go
« no previous file with comments
|
« test/fixedbugs/bug324.dir/main.go
('k') |
test/golden.out »
('j') |
no next file with comments »
Issue 4442071: code review 4442071: gc: correct handling of unexported method names in embe... (Closed)
Created 13 years, 11 months ago by rsc
Modified 13 years, 11 months ago
Reviewers:
Base URL:
Comments: 1
Recent Issues
|
This issue
This is Rietveld
f62528b