Issue 4441072: Enable the html caja serializer + tests

Issue 4441072: Enable the html caja serializer + tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by Jasvir

Modified:
14 years, 6 months ago

Reviewers:
johnfargo, plindner1, fargo

CC:
shindig.remailer_gmail.com

Base URL:
https://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

* enables rendering of doctypes for caja parser consistent with neko * enables the running of serialization tests for the caja parser

Patch Set 2 : removed stale comment #

Total comments: 2

Patch Set 3 : Eliminate deadcode #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -13 lines)			Patch
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlParser.java	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java	View	1 2	2 chunks	+6 lines, -10 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/HtmlSerializationTest.java	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

johnfargo

LGTM++ http://codereview.appspot.com/4441072/diff/3001/java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java (right): http://codereview.appspot.com/4441072/diff/3001/java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java#newcode42 java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java:42: MarkupRenderMode.XML : MarkupRenderMode.HTML; not saying it's wrong, but ...

14 years, 8 months ago (2011-04-28 02:00:57 UTC) #2

Jasvir

http://codereview.appspot.com/4441072/diff/3001/java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java (right): http://codereview.appspot.com/4441072/diff/3001/java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java#newcode42 java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java:42: MarkupRenderMode.XML : MarkupRenderMode.HTML; Actually we're rendering the entire document ...

14 years, 8 months ago (2011-04-28 02:37:00 UTC) #3

fargo

14 years, 8 months ago (2011-04-28 02:48:27 UTC) #4

Happy to have "helped"

On Wed, Apr 27, 2011 at 7:37 PM, <jasvir@gmail.com> wrote:

>
>
>
http://codereview.appspot.com/4441072/diff/3001/java/gadgets/src/main/java/or...
> File
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java
> (right):
>
>
>
http://codereview.appspot.com/4441072/diff/3001/java/gadgets/src/main/java/or...
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlSerializer.java:42:
> MarkupRenderMode.XML : MarkupRenderMode.HTML;
> Actually we're rendering the entire document - it's doing a no-op.
> Nuked.
>
>
> On 2011/04/28 02:00:57, johnfargo wrote:
>
>> not saying it's wrong, but could you enlighten me on exactly what this
>>
> is doing?
>
>> Introspecting into the content for a strict doctype or similar?
>>
>
> http://codereview.appspot.com/4441072/
>

Expand All Messages | Collapse All Messages