Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(45)

Issue 444044: Handle color background of one2many and many2many for issue1355 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 11 months ago by ced
Modified:
15 years, 11 months ago
Reviewers:
bch, h.goebel, yangoon1
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Simplify the code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M tryton/gui/window/view_form/view/form_gtk/interface.py View 1 2 chunks +2 lines, -0 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/many2many.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/one2many.py View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4
ced
15 years, 11 months ago (2010-03-12 19:41:47 UTC) #1
yangoon1
15 years, 11 months ago (2010-03-13 01:02:42 UTC) #2
h.goebel
http://codereview.appspot.com/444044/diff/1/4 File tryton/gui/window/view_form/view/form_gtk/one2many.py (right): http://codereview.appspot.com/444044/diff/1/4#newcode175 tryton/gui/window/view_form/view/form_gtk/one2many.py:175: def _color_widget(self): duplicate code. What about using a mix-in?
15 years, 11 months ago (2010-03-14 18:29:26 UTC) #3
ced
15 years, 11 months ago (2010-03-14 19:54:31 UTC) #4

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b