Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 4438080: Don't constantly recreate index buffers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by John Bauman
Modified:
3 years, 10 months ago
Reviewers:
dgkoch, nicolas
CC:
angleproject-review_googlegroups.com
Base URL:
https://angleproject.googlecode.com/svn/trunk
Visibility:
Public.

Description

Don't constantly recreate index buffers. Recreating index buffers for closing loops can take a long time, so use a streaming index buffer instead. BUG= TEST= Committed: http://code.google.com/p/angleproject/source/detail?r=625

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -25 lines) Patch
M src/libGLESv2/Context.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/libGLESv2/Context.cpp View 4 chunks +40 lines, -25 lines 2 comments Download

Messages

Total messages: 3
John Bauman
Split out the index buffer part.
3 years, 10 months ago (2011-04-28 02:13:36 UTC) #1
dgkoch
minor nit re sizeof calculations. LGTM after those are fixed. I didn't realize the canvas ...
3 years, 10 months ago (2011-04-28 03:07:31 UTC) #2
nicolas
3 years, 10 months ago (2011-04-28 10:34:09 UTC) #3
FYI, I've created a Wiki page to document the Buffer implementation
(http://code.google.com/p/angleproject/wiki/BufferImplementation). Note that it
likely needs updating after committing these changes.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1437:571d95b2634e