Add the ability to translate arbritary XML into JSON

Add code to translate abritrary XML into a JSON object. This would be a small enhancement to the functionality already in the gadgets.json namespace.

[rbaxter85, 2011-04-26 00:39:02]

On 2011/04/26 00:37:57, rbaxter85 wrote:
Jira: https://issues.apache.org/jira/browse/SHINDIG-1529

[johnfargo, 2011-04-26 01:14:49]

thoughts welcome.

http://codereview.appspot.com/4438071/diff/1/features/src/main/javascript/fea...
File features/src/main/javascript/features/core.json/feature.xml (right):

http://codereview.appspot.com/4438071/diff/1/features/src/main/javascript/fea...
features/src/main/javascript/features/core.json/feature.xml:33: <exports
type="js">gadgets.json.convertXmlToJson</exports>
since there are no deps between this file and the rest of gadgets.json, let's
split this off into a subfeature. Suggestion: gadgets.json.xml. Doing so will
avoid putting additional size burden on those who want only to load the "core"
JSON methods themselves.

http://codereview.appspot.com/4438071/diff/1/features/src/main/javascript/fea...
File features/src/main/javascript/features/core.json/json-xmltojson.js (right):

http://codereview.appspot.com/4438071/diff/1/features/src/main/javascript/fea...
features/src/main/javascript/features/core.json/json-xmltojson.js:32: //Integer
which represents a text node
I'm getting some spacing issues here -- tabs perhaps rather than 2-space indent?

[rbaxter85, 2011-04-26 23:09:24]

Thanks for the comments John.  I am fine with moving this functionality out of
the core code, but I am debating where it should go....should I create a
completely new feature or maybe we could add it to the xmlutil feature.  Paul
had mentioned that the xmlutil feature is used for templating code.  I just
didn't want to create a whole new feature just for one simple function, unless
everyone agrees thats the best thing to do.  Thoughts?

On 2011/04/26 01:14:49, johnfargo wrote:
> thoughts welcome.
> 
>
http://codereview.appspot.com/4438071/diff/1/features/src/main/javascript/fea...
> File features/src/main/javascript/features/core.json/feature.xml (right):
> 
>
http://codereview.appspot.com/4438071/diff/1/features/src/main/javascript/fea...
> features/src/main/javascript/features/core.json/feature.xml:33: <exports
> type="js">gadgets.json.convertXmlToJson</exports>
> since there are no deps between this file and the rest of gadgets.json, let's
> split this off into a subfeature. Suggestion: gadgets.json.xml. Doing so will
> avoid putting additional size burden on those who want only to load the "core"
> JSON methods themselves.
> 
>
http://codereview.appspot.com/4438071/diff/1/features/src/main/javascript/fea...
> File features/src/main/javascript/features/core.json/json-xmltojson.js
(right):
> 
>
http://codereview.appspot.com/4438071/diff/1/features/src/main/javascript/fea...
> features/src/main/javascript/features/core.json/json-xmltojson.js:32:
//Integer
> which represents a text node
> I'm getting some spacing issues here -- tabs perhaps rather than 2-space
indent?

[johnfargo, 2011-04-27 01:52:22]

I'm happy leaving it to you -- but these days I've been creating pretty
fine-grained features. It's really just a matter of convenience vs.
optimization in JS bundles.

On Tue, Apr 26, 2011 at 4:09 PM, <rbaxter85@gmail.com> wrote:

> Thanks for the comments John.  I am fine with moving this functionality
> out of the core code, but I am debating where it should go....should I
> create a completely new feature or maybe we could add it to the xmlutil
> feature.  Paul had mentioned that the xmlutil feature is used for
> templating code.  I just didn't want to create a whole new feature just
> for one simple function, unless everyone agrees thats the best thing to
> do.  Thoughts?
>
>
> On 2011/04/26 01:14:49, johnfargo wrote:
>
>> thoughts welcome.
>>
>
>
>
>
http://codereview.appspot.com/4438071/diff/1/features/src/main/javascript/fea...
>
>> File features/src/main/javascript/features/core.json/feature.xml
>>
> (right):
>
>
>
>
http://codereview.appspot.com/4438071/diff/1/features/src/main/javascript/fea...
>
>> features/src/main/javascript/features/core.json/feature.xml:33:
>>
> <exports
>
>> type="js">gadgets.json.convertXmlToJson</exports>
>> since there are no deps between this file and the rest of
>>
> gadgets.json, let's
>
>> split this off into a subfeature. Suggestion: gadgets.json.xml. Doing
>>
> so will
>
>> avoid putting additional size burden on those who want only to load
>>
> the "core"
>
>> JSON methods themselves.
>>
>
>
>
>
http://codereview.appspot.com/4438071/diff/1/features/src/main/javascript/fea...
>
>> File features/src/main/javascript/features/core.json/json-xmltojson.js
>>
> (right):
>
>
>
>
http://codereview.appspot.com/4438071/diff/1/features/src/main/javascript/fea...
>
>> features/src/main/javascript/features/core.json/json-xmltojson.js:32:
>>
> //Integer
>
>> which represents a text node
>> I'm getting some spacing issues here -- tabs perhaps rather than
>>
> 2-space indent?
>
>
>
> http://codereview.appspot.com/4438071/
>

[rbaxter85, 2011-04-27 14:41:27]

Updated patch with John's Suggestions

[rbaxter85, 2011-04-29 13:17:18]

John when you get a chance could you review my updated changes?  Thanks!

On 2011/04/27 14:41:27, rbaxter85 wrote:
> Updated patch with John's Suggestions

[rjbaxter_us.ibm.com, 2011-05-03 12:34:21]

Could someone please complete this code review for me and deliver the 
code?  This issue has been open for a while and I have had trouble finding 
someone to finish the code review and deliver the code.  Thanks.

-Ryan

Email: rjbaxter@us.ibm.com
Phone: 978-899-3041
developerWorks Profile



From:   rbaxter85@gmail.com
To:     dev@shindig.apache.org, johnfargo@gmail.com, 
Cc:     reply@codereview.appspotmail.com
Date:   04/29/2011 11:24 AM
Subject:        Re: Add the ability to translate arbritary XML into JSON 
(issue4438071)



John when you get a chance could you review my updated changes?  Thanks!

On 2011/04/27 14:41:27, rbaxter85 wrote:
> Updated patch with John's Suggestions



http://codereview.appspot.com/4438071/

[johnfargo, 2011-05-03 20:19:55]

Hi Ryan,

I was trying to do so, but found that EndToEndTest still fails for me. Thoughts?
Failed tests: 
  jsonParse(org.apache.shindig.server.endtoend.EndToEndTest): test method
jsonConvertXmlToJsonTest did not finish


--j

On 2011/05/03 12:34:21, rjbaxter_us.ibm.com wrote:
> Could someone please complete this code review for me and deliver the 
> code?  This issue has been open for a while and I have had trouble finding 
> someone to finish the code review and deliver the code.  Thanks.
> 
> -Ryan
> 
> Email: mailto:rjbaxter@us.ibm.com
> Phone: 978-899-3041
> developerWorks Profile
> 
> 
> 
> From:   mailto:rbaxter85@gmail.com
> To:     mailto:dev@shindig.apache.org, mailto:johnfargo@gmail.com, 
> Cc:     mailto:reply@codereview.appspotmail.com
> Date:   04/29/2011 11:24 AM
> Subject:        Re: Add the ability to translate arbritary XML into JSON 
> (issue4438071)
> 
> 
> 
> John when you get a chance could you review my updated changes?  Thanks!
> 
> On 2011/04/27 14:41:27, rbaxter85 wrote:
> > Updated patch with John's Suggestions
> 
> 
> 
> http://codereview.appspot.com/4438071/
> 
> 
>