src/pkg/exec/exec_test.go - Issue 4435059: code review 4435059: syscall: correct Windows CreateProcess input parameters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/exec/exec_test.go

Issue 4435059: code review 4435059: syscall: correct Windows CreateProcess input parameters (Closed)

Patch Set: diff -r 79deef5a2706 https://go.googlecode.com/hg/ Created 13 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/exec/exec_test.go

===================================================================

--- a/src/pkg/exec/exec_test.go

+++ b/src/pkg/exec/exec_test.go

@@ -9,19 +9,14 @@

"io/ioutil"

"testing"

"os"

- "runtime"

)

func run(argv []string, stdin, stdout, stderr int) (p *Cmd, err os.Error) {

- if runtime.GOOS == "windows" {

- argv = append([]string{"cmd", "/c"}, argv...)

- }

exe, err := LookPath(argv[0])

if err != nil {

return nil, err

}

- p, err = Run(exe, argv, nil, "", stdin, stdout, stderr)

- return p, err

+ return Run(exe, argv, nil, "", stdin, stdout, stderr)

}

func TestRunCat(t *testing.T) {

« no previous file with comments | « src/cmd/gotest/gotest.go ('k') | src/pkg/syscall/exec_windows.go » ('j') | no next file with comments »