code review 4435059: syscall: correct Windows CreateProcess input parameters

src/pkg/syscall/exec_windows.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 // Fork, exec, wait, etc.
 
 package syscall
 
 import (
         "sync"
+        "unsafe"
         "utf16"
 )
 
 var ForkLock sync.RWMutex
 
 // escape rewrites command line argument s as prescribed
 // in http://msdn.microsoft.com/en-us/library/ms880421.
 // This function returns "" (2 double quotes) if s is empty.
 // Alternatively, these transformations are done:
 // - every back slash (\) is doubled, but only if immediately
@@ skipping 251 matching lines @@
         for i := range attr.Files {
                 if attr.Files[i] > 0 {
                         err := DuplicateHandle(p, int32(attr.Files[i]), p, &fd[i], 0, true, DUPLICATE_SAME_ACCESS)
                         if err != 0 {
                                 return 0, 0, err
                         }
                         defer CloseHandle(int32(fd[i]))
                 }
         }
         si := new(StartupInfo)
-        GetStartupInfo(si)
+        si.Cb = uint32(unsafe.Sizeof(*si))
         si.Flags = STARTF_USESTDHANDLES
         si.StdInput = fd[0]
         si.StdOutput = fd[1]
         si.StdErr = fd[2]
 
         pi := new(ProcessInformation)
 
         err = CreateProcess(argv0p, argvp, nil, nil, true, CREATE_UNICODE_ENVIRONMENT, createEnvBlock(attr.Env), dirp, si, pi)
         if err != 0 {
                 return 0, 0, err
         }
         defer CloseHandle(pi.Thread)
 
         return int(pi.ProcessId), int(pi.Process), 0
 }
 
 func Exec(argv0 string, argv []string, envv []string) (err int) {
         return EWINDOWS
 }