code review 4432079: cgi: set Request.TLS and Request.RemoteAddr for children

cgi: set Request.TLS and Request.RemoteAddr for children

[bradfitz, 2011-04-28 20:46:32]

Hello agl, eds (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[rsc1, 2011-04-28 20:48:58]

LGTM

I think the normal http packages's RemoteAddr has a :port.
Maybe add :0?

[bradfitz, 2011-04-28 20:57:25]

Hello agl, eds, rsc1 (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-04-28 21:00:56]

http://codereview.appspot.com/4432079/diff/1002/src/pkg/http/cgi/child.go
File src/pkg/http/cgi/child.go (right):

http://codereview.appspot.com/4432079/diff/1002/src/pkg/http/cgi/child.go#new...
src/pkg/http/cgi/child.go:196: // Copied from package net's JoinHostPort. Silly
to depend on all of
at least two of the packages you imported depend on net

[bradfitz, 2011-04-28 21:01:54]

http://codereview.appspot.com/4432079/diff/1002/src/pkg/http/cgi/child.go
File src/pkg/http/cgi/child.go (right):

http://codereview.appspot.com/4432079/diff/1002/src/pkg/http/cgi/child.go#new...
src/pkg/http/cgi/child.go:196: // Copied from package net's JoinHostPort. Silly
to depend on all of
On 2011/04/28 21:00:56, rsc wrote:
> at least two of the packages you imported depend on net

sigh, right.

[bradfitz, 2011-04-28 21:02:26]

Hello agl, eds, rsc1, rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-04-28 21:11:30]

LGTM

It's okay to import net just for one function, by the way.
The stuff that isn't called (like Dial) won't be linked in.

[bradfitz, 2011-04-28 21:30:20]

On Thu, Apr 28, 2011 at 2:11 PM, <rsc@golang.org> wrote:

> LGTM
>
> It's okay to import net just for one function, by the way.
> The stuff that isn't called (like Dial) won't be linked in.


oh?  last I thought I heard it still was.  I only even considered
duplicating the code due to previous advice (perhaps I misremember?) to
avoid linking in too much.

good to hear, though.

[eds, 2011-04-28 21:51:06]

LGTM

[bradfitz, 2011-04-28 22:02:34]

*** Submitted as http://code.google.com/p/go/source/detail?r=b1734b25f062 ***

cgi: set Request.TLS and Request.RemoteAddr for children

R=agl, eds, rsc1, rsc
CC=golang-dev
http://codereview.appspot.com/4432079