Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(76)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
4432067
: Fix issue 1348 (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 11 months ago by
MikeSamuel
Modified:
14 years, 9 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.
Description
Fix problem with optimizing dot operators in the minifier.
Patch Set 1
#
Created:
14 years, 11 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+85 lines, -36 lines
)
Patch
M
src/com/google/caja/ancillary/opt/StatementSimplifier.java
View
2 chunks
+21 lines, -5 lines
0 comments
Download
M
src/com/google/caja/demos/playground/server/AppEngineJobCache.java
View
4 chunks
+5 lines, -2 lines
0 comments
Download
M
src/com/google/caja/demos/playground/server/AppEngineJobCacheKey.java
View
2 chunks
+4 lines, -3 lines
0 comments
Download
M
src/com/google/caja/lang/css/JSRE.java
View
3 chunks
+2 lines, -3 lines
0 comments
Download
M
src/com/google/caja/lang/html/HtmlDefinitions.java
View
7 chunks
+6 lines, -8 lines
0 comments
Download
M
src/com/google/caja/parser/AbstractParseTreeNode.java
View
2 chunks
+3 lines, -2 lines
0 comments
Download
M
src/com/google/caja/parser/js/Operation.java
View
2 chunks
+15 lines, -1 line
0 comments
Download
M
src/com/google/caja/plugin/CssRuleRewriter.java
View
4 chunks
+0 lines, -4 lines
0 comments
Download
M
src/com/google/caja/plugin/stages/StubJobCache.java
View
3 chunks
+1 line, -3 lines
0 comments
Download
M
tests/com/google/caja/ancillary/opt/JsOptimizerTest.java
View
2 chunks
+23 lines, -0 lines
0 comments
Download
M
tests/com/google/caja/parser/html/NodesTest.java
View
4 chunks
+5 lines, -4 lines
0 comments
Download
M
tests/com/google/caja/plugin/PipelineCacheTest.java
View
1 chunk
+0 lines, -1 line
0 comments
Download
Messages
Total messages: 2
Expand All Messages
|
Collapse All Messages
MikeSamuel
14 years, 11 months ago (2011-04-26 01:12:23 UTC)
#1
Sign in
to reply to this message.
Jasvir
LGTM Thanks for the warnings fixups.
14 years, 11 months ago (2011-04-26 05:09:23 UTC)
#2
LGTM Thanks for the warnings fixups.
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 4432067: Fix issue 1348 (Closed)
Created 14 years, 11 months ago by MikeSamuel
Modified 14 years, 9 months ago
Reviewers: Jasvir
Base URL: http://google-caja.googlecode.com/svn/trunk/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b
