Issue 4431056: Get rid of GTypeModule for class finalizer, as all engines are now static.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4431056: Get rid of GTypeModule for class finalizer, as all engines are now static. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by Daiki Ueno

Modified:
14 years, 10 months ago

Reviewers:
shawn.p.huang

CC:
fujiwara

Base URL:
git@github.com:ibus/ibus-m17n.git@master

Visibility:
Public.

Description

Get rid of GTypeModule for class finalizer, as all engines are now static. BUG=https://bugzilla.redhat.com/show_bug.cgi?id=696476#c9 TEST=manual

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix alignment #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -88 lines)			Patch
	M	src/engine.c	View	1	7 chunks	+9 lines, -88 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Daiki Ueno

This patch supersedes http://codereview.appspot.com/4447056/.

14 years, 10 months ago (2011-04-21 03:37:03 UTC) #1

Peng

14 years, 10 months ago (2011-04-27 02:00:08 UTC) #2

LGTM

http://codereview.appspot.com/4431056/diff/1/src/engine.c
File src/engine.c (right):

http://codereview.appspot.com/4431056/diff/1/src/engine.c#newcode178
src/engine.c:178: (GClassFinalizeFunc)NULL,
It is better like align them like:

(xxx)    NULL,
(yyyyy)  xxxx,
(zzz)    zzz,
...

Expand All Messages | Collapse All Messages