Issue 4430068: JsCompiler.compile() no longers throws JsException

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4430068: JsCompiler.compile() no longers throws JsException (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by mhermanto

Modified:
14 years, 10 months ago

Reviewers:
johnfargo, fargo

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

... in favor of already-provided Http return code and more extensible error-building in JsResponse.

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -40 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/CompilationProcessor.java	View	1	2 chunks	+8 lines, -4 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsResponse.java	View	1	2 chunks	+16 lines, -1 line	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/js/JsCompiler.java	View		2 chunks	+1 line, -5 lines	0 comments	Download
java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java	View	1	5 chunks	+30 lines, -15 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/js/CompilationProcessorTest.java	View		1 chunk	+0 lines, -15 lines	0 comments	Download

Total messages: 2

LGTM++

On 2011/04/27 02:07:57, mhermanto wrote: