Issue 4428075: Unbreak parser related build breakage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4428075: Unbreak parser related build breakage (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by Jasvir

Modified:
14 years, 8 months ago

Reviewers:
johnfargo, zhoresh

CC:
dev_shindig.apache.org

Base URL:
https://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

If DefaultHtmlSerializer is injected and used to render DOM nodes parsed by Caja, xmlns attributes do not get rendered. Adds a parameter to the constructor so a non-injected serializer can be used for testing. Adds @Ignore to osdata test which Caja can parse but not render in original form. @1097675

Patch Set 1 #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -0 lines)			Patch
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/GadgetHtmlParser.java	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaHtmlParser.java	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/HtmlSerializationTest.java	View	3 chunks	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages