code review 4423043: changes for more restricted reflect.SetValue

src/pkg/json/decode_test.go

 // Copyright 2010 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package json
 
 import (
         "bytes"
         "os"
         "reflect"
@@ skipping 120 matching lines @@
                 if err := checkValid(in, &scan); err != nil {
                         if !reflect.DeepEqual(err, tt.err) {
                                 t.Errorf("#%d: checkValid: %#v", i, err)
                                 continue
                         }
                 }
                 if tt.ptr == nil {
                         continue
                 }
                 // v = new(right-type)
-                v := reflect.NewValue(tt.ptr)
-                v.Set(reflect.Zero(v.Type().Elem()).Addr())
+                v := reflect.New(reflect.Typeof(tt.ptr).Elem())
                 if err := Unmarshal([]byte(in), v.Interface()); !reflect.DeepEqual(err, tt.err) {
                         t.Errorf("#%d: %v want %v", i, err, tt.err)
                         continue
                 }
                 if !reflect.DeepEqual(v.Elem().Interface(), tt.out) {
                         t.Errorf("#%d: mismatch\nhave: %#+v\nwant: %#+v", i, v.Elem().Interface(), tt.out)
                         data, _ := Marshal(v.Elem().Interface())
                         println(string(data))
                         data, _ = Marshal(tt.out)
                         println(string(data))
@@ skipping 379 matching lines @@
         },
         "PSmall": null,
         "PPSmall": {
                 "Tag": "tag31"
         },
         "Interface": null,
         "PInterface": 5.2
 }`
 
 var pallValueCompact = strings.Map(noSpace, pallValueIndent)