Issue 4419042: code review 4419042: http: consume request bodies before replying

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4419042: code review 4419042: http: consume request bodies before replying (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by bradfitz

Modified:
13 years, 11 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

http: consume request bodies before replying This fixes our http behavior (even if Handlers forget to consume a request body, we do it for them before we send their response header), fixes the racy TestServerExpect, and adds TestServerConsumesRequestBody. With GOMAXPROCS>1, the http tests now seem race-free.

Patch Set 1 #

Patch Set 2 : diff -r 55f226a3373e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 55f226a3373e https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 55f226a3373e https://go.googlecode.com/hg/ #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -1 line)			Patch
	M	src/pkg/http/serve_test.go	View	1	2 chunks	+47 lines, -1 line	0 comments	Download
	M	src/pkg/http/server.go	View	1	3 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 11 months ago (2011-04-14 17:35:08 UTC) #1

rsc

LGTM Cool. I was sure this was going to be a garbage collector bug.

13 years, 11 months ago (2011-04-14 17:36:34 UTC) #2

bradfitz

13 years, 11 months ago (2011-04-14 17:40:28 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=4737da6a350e ***

http: consume request bodies before replying

This fixes our http behavior (even if Handlers forget to
consume a request body, we do it for them before we send
their response header), fixes the racy TestServerExpect,
and adds TestServerConsumesRequestBody.

With GOMAXPROCS>1, the http tests now seem race-free.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4419042

Expand All Messages | Collapse All Messages