Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(629)

Issue 4406044: code review 4406044: gofmt: gofmt -s -w src misc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by gri
Modified:
13 years, 3 months ago
Reviewers:
CC:
r, bradfitzgoog, golang-dev
Visibility:
Public.

Description

gofmt: gofmt -s -w src misc

Patch Set 1 #

Patch Set 2 : diff -r 54b2790403aa https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c914446800f8 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c914446800f8 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r c914446800f8 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 6 : diff -r 74f09f893ca9 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M src/cmd/godoc/format.go View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/rsa/pkcs1v15.go View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M src/pkg/crypto/tls/common.go View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/tls/handshake_messages_test.go View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/hash/fnv/fnv_test.go View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/http/export_test.go View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/dir_plan9.go View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/exec_windows.go View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/syscall_plan9.go View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
gri
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 3 months ago (2011-04-13 21:28:01 UTC) #1
r
LGTM
13 years, 3 months ago (2011-04-13 21:34:12 UTC) #2
bradfitzgoog
http://codereview.appspot.com/4406044/diff/11/src/pkg/http/export_test.go File src/pkg/http/export_test.go (right): http://codereview.appspot.com/4406044/diff/11/src/pkg/http/export_test.go#newcode17 src/pkg/http/export_test.go:17: for key := range t.idleConn { hm, now my ...
13 years, 3 months ago (2011-04-13 21:56:09 UTC) #3
gri
13 years, 3 months ago (2011-04-13 22:14:18 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=fa89b3ebfbc9 ***

gofmt: gofmt -s -w src misc

R=r, bradfitzwork
CC=golang-dev
http://codereview.appspot.com/4406044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b