Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(109)

Issue 4398045: Add the openSocial namespace to entries from the activity stream produced by Shindig

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 9 months ago by rbaxter85
Modified:
11 years, 3 months ago
Reviewers:
henry.saputra, woodser
CC:
dev_shindig.apache.org
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Part of the migration of some of the OpenSocial components to activity streams involves namespacing some of the OpenSocial properties that do not match to Activity Stream properties. This patch adds the openSocial namespace to the activity streams implementation so we can begin to build out these OpenSocial extensions.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -6 lines) Patch
content/sampledata/canonicaldb.json View 1 chunk +2 lines, -1 line 0 comments Download
java/social-api/src/main/java/org/apache/shindig/social/core/model/ActivityEntryImpl.java View 3 chunks +13 lines, -0 lines 0 comments Download
java/social-api/src/main/java/org/apache/shindig/social/core/model/OpenSocialImpl.java View 1 chunk +13 lines, -0 lines 0 comments Download
java/social-api/src/main/java/org/apache/shindig/social/core/util/xstream/XStream081Configuration.java View 4 chunks +4 lines, -0 lines 0 comments Download
java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/ActivityEntry.java View 2 chunks +16 lines, -1 line 0 comments Download
java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/OpenSocial.java View 1 chunk +44 lines, -0 lines 0 comments Download
java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json View 1 chunk +2 lines, -1 line 0 comments Download
java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonId.json View 1 chunk +2 lines, -1 line 0 comments Download
java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json View 1 chunk +2 lines, -1 line 0 comments Download
java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonUpdated.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
rbaxter85
14 years, 9 months ago (2011-04-13 17:37:06 UTC) #1
henry.saputra
Hi Ryan, Could you change the base URL for the codereview from "http://svn.apache.org/repos/asf/incubator/shindig/trunk/" to http://svn.apache.org/repos/asf/shindig/trunk/ ...
14 years, 9 months ago (2011-04-13 18:42:37 UTC) #2
rbaxter85
14 years, 9 months ago (2011-04-13 18:48:12 UTC) #3
Ah thats why the diffs weren't working.  Should be all set now.

On 2011/04/13 18:42:37, henry.saputra wrote:
> Hi Ryan,
> 
> Could you change the base URL for the codereview from
> "http://svn.apache.org/repos/asf/incubator/shindig/trunk/" to
> http://svn.apache.org/repos/asf/shindig/trunk/ ?
> 
> - Henry
> 
> On Wed, Apr 13, 2011 at 10:37 AM,  <mailto:rbaxter85@gmail.com> wrote:
> > Reviewers: http://woodser_us.ibm.com,
> >
> > Description:
> > Part of the migration of some of the OpenSocial components to activity
> > streams involves namespacing some of the OpenSocial properties that do
> > not match to Activity Stream properties. This patch adds the openSocial
> > namespace to the activity streams implementation so we can begin to
> > build out these OpenSocial extensions.
> >
> > Please review this at http://codereview.appspot.com/4398045/
> >
> > Affected files:
> > &nbsp;content/sampledata/canonicaldb.json
> >
>
&nbsp;java/social-api/src/main/java/org/apache/shindig/social/core/model/ActivityEntryImpl.java
> >
>
&nbsp;java/social-api/src/main/java/org/apache/shindig/social/core/model/OpenSocialImpl.java
> >
>
&nbsp;java/social-api/src/main/java/org/apache/shindig/social/core/util/xstream/XStream081Configuration.java
> >
>
&nbsp;java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/ActivityEntry.java
> >
>
&nbsp;java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/OpenSocial.java
> >
>
&nbsp;java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json
> >
>
&nbsp;java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonId.json
> >
>
&nbsp;java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json
> >
>
&nbsp;java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonUpdated.json
> >
> >
> >
> 
> 
> 
> -- 
> Thanks,
> Henry
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b