Issue 4383048: Use caja.js api to render the playground

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4383048: Use caja.js api to render the playground (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by Jasvir

Modified:
15 years, 1 month ago

Reviewers:
ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Removes extraneous ES53 setup in the playground in favor of caja.js * ensure es53-taming files get copied now that they're called opt rather than minified * remove valija/cajita js files * add the caja.js api * remove taming.js * fix up policy.js to use the new api * rewire alert to use GWT alert rather than the browser native alert @4478

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use caja.js api to render the playground #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -403 lines)			Patch
M	src/com/google/caja/demos/playground/Playground.html	View	1	1 chunk	+1 line, -13 lines	0 comments	Download
M	src/com/google/caja/demos/playground/client/policy.js	View	1	1 chunk	+16 lines, -216 lines	0 comments	Download
M	src/com/google/caja/demos/playground/client/ui/PlaygroundView.java	View	1	5 chunks	+86 lines, -33 lines	0 comments	Download
D	src/com/google/caja/demos/playground/taming.js	View	1	1 chunk	+0 lines, -141 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Jasvir

This is ready for initial review, however, the flash taming needs to be fixed in ...

15 years, 2 months ago (2011-04-09 18:12:30 UTC) #2

ihab.awad

lgtm modulo what you want me to do with 'policy.js'. http://codereview.appspot.com/4383048/diff/1/src/com/google/caja/demos/playground/client/policy.js File src/com/google/caja/demos/playground/client/policy.js (right): http://codereview.appspot.com/4383048/diff/1/src/com/google/caja/demos/playground/client/policy.js#newcode1 ...

15 years, 2 months ago (2011-04-14 20:24:14 UTC) #3

Jasvir

15 years, 1 month ago (2011-05-20 22:43:08 UTC) #4

http://codereview.appspot.com/4383048/diff/1/src/com/google/caja/demos/playgr...
File src/com/google/caja/demos/playground/client/policy.js (right):

http://codereview.appspot.com/4383048/diff/1/src/com/google/caja/demos/playgr...
src/com/google/caja/demos/playground/client/policy.js:1: // Playground policy
Removing support for flash till flash taming is rewritten for caja.js

On 2011/04/14 20:24:14, ihab.awad wrote:
> How much of this do you want me to review? Some of it talks about Valija and
> stuff ....

Expand All Messages | Collapse All Messages