code review 4383047: ld: 25% faster

src/cmd/ld/pe.c

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 // PE (Portable Executable) file writing
 // http://www.microsoft.com/whdc/system/platform/firmware/PECOFF.mspx
 
 #include <time.h>
 
 #include "l.h"
@@ skipping 153 matching lines @@
         if(n%2)
                 cput('\0');
 }
 
 static Dll*·
 initdynimport(void)
 {
         Imp *m;
         Dll *d;
         Sym *s, *dynamic;
-        int i;
 
         dr = nil;
 ········
-        for(i=0; i<NHASH; i++)
-        for(s = hash[i]; s != S; s = s->hash) {
+        for(s = allsym; s != S; s = s->allsym) {
                 if(!s->reachable || !s->dynimpname || s->dynexport)
                         continue;
                 for(d = dr; d != nil; d = d->next) {
                         if(strcmp(d->name,s->dynimplib) == 0) {
                                 m = mal(sizeof *m);
                                 break;
                         }
                 }
                 if(d == nil) {
                         d = mal(sizeof *d);
@@ skipping 115 matching lines @@
         Sym *s1, *s2;
 
         s1 = *(Sym**)p1;
         s2 = *(Sym**)p2;
         return strcmp(s1->dynimpname, s2->dynimpname);
 }
 
 static void
 initdynexport(void)
 {
-        int i;
         Sym *s;
 ········
         nexport = 0;
-        for(i=0; i<NHASH; i++)
-        for(s = hash[i]; s != S; s = s->hash) {
+        for(s = allsym; s != S; s = s->allsym) {
                 if(!s->reachable || !s->dynimpname || !s->dynexport)
                         continue;
                 if(nexport+1 > sizeof(dexport)/sizeof(dexport[0])) {
                         diag("pe dynexport table is full");
                         errorexit();
                 }
 ················
                 dexport[nexport] = s;
                 nexport++;
         }
@@ skipping 200 matching lines @@
         else
                 set(Subsystem, IMAGE_SUBSYSTEM_WINDOWS_CUI);
         set(SizeOfStackReserve, 0x0040000);
         set(SizeOfStackCommit, 0x00001000);
         set(SizeOfHeapReserve, 0x00100000);
         set(SizeOfHeapCommit, 0x00001000);
         set(NumberOfRvaAndSizes, 16);
 
         pewrite();
 }