Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(304)

Issue 4372043: s/getReceiverOrigin/getTargetOrigin/ (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 11 months ago by mhermanto
Modified:
14 years, 10 months ago
Reviewers:
fargo
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
features/src/main/javascript/features/rpc/feature.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
mhermanto
14 years, 11 months ago (2011-04-08 01:10:59 UTC) #1
fargo
14 years, 11 months ago (2011-04-08 01:53:17 UTC) #2
LGTM++

On Thu, Apr 7, 2011 at 6:10 PM, <mhermanto@gmail.com> wrote:

> Reviewers: fargo,
>
>
>
> Please review this at http://codereview.appspot.com/4372043/
>
> Affected files:
>  features/src/main/javascript/features/rpc/feature.xml
>
>
> ### Eclipse Workspace Patch 1.0
> #P shindig-project
> Index: features/src/main/javascript/features/rpc/feature.xml
> ===================================================================
> --- features/src/main/javascript/features/rpc/feature.xml       (revision
> 1088830)
> +++ features/src/main/javascript/features/rpc/feature.xml       (working
> copy)
> @@ -41,7 +41,7 @@
>       <exports type="js">gadgets.rpc.receive</exports>
>       <exports type="js">gadgets.rpc.receiveSameDomain</exports>
>       <exports type="js">gadgets.rpc.getOrigin</exports>
> -      <exports type="js">gadgets.rpc.getReceiverOrigin</exports>
> +      <exports type="js">gadgets.rpc.getTargetOrigin</exports>
>     </api>
>     <script src="wpm.transport.js"/>
>     <script src="flash.transport.js"/>
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b