Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(102)

Issue 43650043: Rename cajoling service to proxy; remove dead code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by kpreid2
Modified:
12 years, 2 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This is a very rough cleanup; the main thing it doesn't do is refactor the individual methods in ProxyServlet to remove unnecessary code. * Combine CajolingServlet, CajolingService, AbstractCajolingHandler, and ProxyHandler into single-purpose class ProxyServlet; remove code relating to supporting multiple handlers. * Rename entry point URL from '/cajole' to '/proxy' and remove unused URL parameters relating to cajoling. * Remove unrelated dead code CssPrettyPrinter, CssMinimalPrinter. @r5649

Patch Set 1 #

Total comments: 7

Patch Set 2 : Rename cajoling service to proxy; remove dead code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -2225 lines) Patch
D src/com/google/caja/parser/quasiliteral/ModuleManager.java View 1 1 chunk +0 lines, -56 lines 0 comments Download
M src/com/google/caja/plugin/caja.js View 1 1 chunk +1 line, -2 lines 0 comments Download
D src/com/google/caja/render/CssMinimalPrinter.java View 1 1 chunk +0 lines, -119 lines 0 comments Download
D src/com/google/caja/render/CssPrettyPrinter.java View 1 1 chunk +0 lines, -186 lines 0 comments Download
D src/com/google/caja/service/AbstractCajolingHandler.java View 1 1 chunk +0 lines, -215 lines 0 comments Download
M src/com/google/caja/service/CajaArguments.java View 1 3 chunks +1 line, -59 lines 0 comments Download
D src/com/google/caja/service/CajolingService.java View 1 1 chunk +0 lines, -331 lines 0 comments Download
M src/com/google/caja/service/CajolingServiceMain.java View 1 1 chunk +0 lines, -61 lines 0 comments Download
D src/com/google/caja/service/CajolingServlet.java View 1 1 chunk +0 lines, -202 lines 0 comments Download
D src/com/google/caja/service/ContentHandler.java View 1 1 chunk +0 lines, -73 lines 0 comments Download
D src/com/google/caja/service/HttpStatus.java View 1 1 chunk +0 lines, -78 lines 0 comments Download
D src/com/google/caja/service/ProxyHandler.java View 1 1 chunk +0 lines, -93 lines 0 comments Download
A + src/com/google/caja/service/ProxyServlet.java View 1 4 chunks +279 lines, -44 lines 0 comments Download
A + src/com/google/caja/service/ProxyServletMain.java View 1 2 chunks +3 lines, -10 lines 0 comments Download
D src/com/google/caja/service/StrictContentTypeCheck.java View 1 1 chunk +0 lines, -43 lines 0 comments Download
M tests/com/google/caja/plugin/BrowserTestCase.java View 1 2 chunks +0 lines, -22 lines 0 comments Download
M tests/com/google/caja/plugin/test-fetch-proxy.js View 1 4 chunks +4 lines, -8 lines 0 comments Download
D tests/com/google/caja/render/CssMinimalPrinterTest.java View 1 1 chunk +0 lines, -48 lines 0 comments Download
D tests/com/google/caja/render/CssPrettyPrinterTest.java View 1 1 chunk +0 lines, -44 lines 0 comments Download
D tests/com/google/caja/render/OrigSourceRendererTestCase.java View 1 1 chunk +0 lines, -128 lines 0 comments Download
D tests/com/google/caja/reporting/TestBuildInfo.java View 1 1 chunk +0 lines, -46 lines 0 comments Download
D tests/com/google/caja/service/AbstractCajolingHandlerTest.java View 1 1 chunk +0 lines, -36 lines 0 comments Download
D tests/com/google/caja/service/CajolingServiceTest.java View 1 1 chunk +0 lines, -107 lines 0 comments Download
D tests/com/google/caja/service/ContentTypeCheckTest.java View 1 1 chunk +0 lines, -62 lines 0 comments Download
D tests/com/google/caja/service/ProxyHandlerTest.java View 1 1 chunk +0 lines, -77 lines 0 comments Download
A + tests/com/google/caja/service/ProxyServletTest.java View 1 3 chunks +66 lines, -42 lines 0 comments Download
M tests/com/google/caja/service/ServiceTestCase.java View 1 4 chunks +3 lines, -20 lines 0 comments Download
M tests/com/google/caja/util/LocalServer.java View 1 2 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 5
kpreid2
12 years, 2 months ago (2013-12-17 22:23:27 UTC) #1
felix8a
lgtm https://codereview.appspot.com/43650043/diff/1/src/com/google/caja/service/ProxyServlet.java File src/com/google/caja/service/ProxyServlet.java (right): https://codereview.appspot.com/43650043/diff/1/src/com/google/caja/service/ProxyServlet.java#newcode70 src/com/google/caja/service/ProxyServlet.java:70: // TODO(kpreid): This code needs cleanup; it has ...
12 years, 2 months ago (2013-12-18 19:43:23 UTC) #2
kpreid2
This is a very rough cleanup; the main thing it doesn't do is refactor the ...
12 years, 2 months ago (2013-12-18 20:33:06 UTC) #3
kpreid2
New snapshot. As well as changes noted below, I deleted some more dead code, namely ...
12 years, 2 months ago (2013-12-18 20:34:36 UTC) #4
felix8a
12 years, 2 months ago (2013-12-19 15:50:08 UTC) #5
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b