Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(591)

Issue 43510044: code review 43510044: database/sql: let drivers access their own driver.Rows.

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 9 months ago by ahormann
Modified:
8 years, 5 months ago
Visibility:
Public.

Description

database/sql: let drivers access their own driver.Rows. When a driver implementing driver.Inspector is registered, it receives a function wich unwrapps the drivers native Rows type from the internal database/sql representation. For some database systems, this enables access to richer metadata like e.g. column types,originating tables of a column or a columns charset. Fixes issue 5606.

Patch Set 1 #

Patch Set 2 : diff -r 12a40bc39413 https://code.google.com/p/go #

Patch Set 3 : diff -r 12a40bc39413 https://code.google.com/p/go #

Patch Set 4 : diff -r 12a40bc39413 https://code.google.com/p/go #

Patch Set 5 : diff -r 12a40bc39413 https://code.google.com/p/go #

Patch Set 6 : diff -r 7e1a4e190b02 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -5 lines) Patch
M src/pkg/database/sql/driver/driver.go View 1 2 3 4 5 1 chunk +20 lines, -0 lines 0 comments Download
M src/pkg/database/sql/fakedb_test.go View 1 2 3 4 5 3 chunks +13 lines, -5 lines 0 comments Download
M src/pkg/database/sql/sql.go View 1 2 3 4 5 2 chunks +21 lines, -0 lines 0 comments Download
M src/pkg/database/sql/sql_test.go View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 11
ahormann
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
8 years, 9 months ago (2013-12-18 08:06:34 UTC) #1
bradfitz
The name and all the empty interfaces in the signature don't look great. The docs ...
8 years, 9 months ago (2013-12-18 11:47:07 UTC) #2
ahormann
Am Mittwoch, 18. Dezember 2013 12:47:05 UTC+1 schrieb Brad Fitzpatrick: > > The name and ...
8 years, 9 months ago (2013-12-18 12:02:17 UTC) #3
bradfitz
On Wed, Dec 18, 2013 at 4:02 AM, <arnehormann@gmail.com> wrote: > > Am Mittwoch, 18. ...
8 years, 9 months ago (2013-12-18 12:04:34 UTC) #4
ahormann
PTAL On 18.12 13:04, Brad Fitzpatrick wrote: > > > > On Wed, Dec 18, ...
8 years, 9 months ago (2013-12-19 08:29:17 UTC) #5
gobot
Replacing golang-dev with golang-codereviews.
8 years, 9 months ago (2013-12-20 16:26:16 UTC) #6
ahormann
ping A recap: Currently, database/sql provides access to column names with Columns. The drivers may ...
8 years, 6 months ago (2014-04-03 08:33:00 UTC) #7
bradfitz
Sorry, we're too late in the Go 1.3 process for this. If you want to ...
8 years, 5 months ago (2014-04-10 16:01:57 UTC) #8
ahormann
On 2014/04/10 16:01:57, bradfitz wrote: > Sorry, we're too late in the Go 1.3 process ...
8 years, 5 months ago (2014-04-10 16:14:59 UTC) #9
bradfitz
Start a golang-dev thread and reference this and the bug. It's true that CLs mailed ...
8 years, 5 months ago (2014-04-10 16:19:38 UTC) #10
bradfitz
8 years, 5 months ago (2014-04-14 22:28:57 UTC) #11
R=close

Until Go 1.4.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b