Adds some extra SES tests

Adds test for IE11 strict nested function defs scoping bug.
Adds stack display to explicit.html
Corrects some typos

[kpreid2, 2013-12-18 04:28:03]

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explic...
File src/com/google/caja/ses/explicit.html (right):

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explic...
src/com/google/caja/ses/explicit.html:156: (function() {
Please add an explanation of what this is testing for. Right now it just logs a
message that doesn't help the user know what it means.

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explic...
src/com/google/caja/ses/explicit.html:168: var stack = 'nothing caught';
Unused variable? Were you meaning to test ses.getStack?

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explic...
src/com/google/caja/ses/explicit.html:171: } catch (er) {
Odd variable name. Please use either 'e' or 'err', whichever is more common in
the codebase.

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explic...
src/com/google/caja/ses/explicit.html:176: })();
}());

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/repair...
File src/com/google/caja/ses/repairES5.js (right):

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/repair...
src/com/google/caja/ses/repairES5.js:4568: preSeverity:
severities.UNSAFE_SPEC_VIOLATION,
Please also add this to the set of acceptNoKnownExploitProblems in caja.js. It
qualifies since it doesn't violate the integrity of Caja itself — it only
affects illegal-in-ES5 code which, if it were to occur in Caja's source, would
be caught by our testing under other browsers.

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/repair...
src/com/google/caja/ses/repairES5.js:4571: sections: [],
Cite the section which prohibits functions inside blocks in strict mode.

[MarkM, 2013-12-18 04:56:23]

Adds test for IE11 strict nested function defs scoping bug.
Adds stack display to explicit.html
Corrects some typos

[MarkM, 2013-12-18 04:58:00]

Adds test for IE11 strict nested function defs scoping bug.
Adds stack display to explicit.html
Corrects some typos

[MarkM, 2013-12-18 04:58:16]

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explic...
File src/com/google/caja/ses/explicit.html (right):

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explic...
src/com/google/caja/ses/explicit.html:156: (function() {
On 2013/12/18 04:28:03, kpreid2 wrote:
> Please add an explanation of what this is testing for. Right now it just logs
a
> message that doesn't help the user know what it means.

Done, by expanding the logged message.

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explic...
src/com/google/caja/ses/explicit.html:168: var stack = 'nothing caught';
On 2013/12/18 04:28:03, kpreid2 wrote:
> Unused variable? Were you meaning to test ses.getStack?

Done. Oops. Holdover from a previous version where I was indeed testing
ses.getStack directly.

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explic...
src/com/google/caja/ses/explicit.html:171: } catch (er) {
On 2013/12/18 04:28:03, kpreid2 wrote:
> Odd variable name. Please use either 'e' or 'err', whichever is more common in
> the codebase.

Done.

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explic...
src/com/google/caja/ses/explicit.html:176: })();
On 2013/12/18 04:28:03, kpreid2 wrote:
> }());

Done. But why?

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/repair...
File src/com/google/caja/ses/repairES5.js (right):

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/repair...
src/com/google/caja/ses/repairES5.js:4568: preSeverity:
severities.UNSAFE_SPEC_VIOLATION,
On 2013/12/18 04:28:03, kpreid2 wrote:
> Please also add this to the set of acceptNoKnownExploitProblems in caja.js. It
> qualifies since it doesn't violate the integrity of Caja itself — it only
> affects illegal-in-ES5 code which, if it were to occur in Caja's source, would
> be caught by our testing under other browsers.

Done.

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/repair...
src/com/google/caja/ses/repairES5.js:4571: sections: [],
On 2013/12/18 04:28:03, kpreid2 wrote:
> Cite the section which prohibits functions inside blocks in strict mode.

I can't find it. Emailing Allen.

[MarkM, 2013-12-18 17:32:14]

Adds test for IE11 strict nested function defs scoping bug.
Adds stack display to explicit.html
Corrects some typos

[MarkM, 2013-12-18 17:32:41]

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/repair...
File src/com/google/caja/ses/repairES5.js (right):

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/repair...
src/com/google/caja/ses/repairES5.js:4571: sections: [],
On 2013/12/18 04:58:16, MarkM wrote:
> On 2013/12/18 04:28:03, kpreid2 wrote:
> > Cite the section which prohibits functions inside blocks in strict mode.
> 
> I can't find it. Emailing Allen.

Done.

[kpreid2, 2013-12-18 18:03:32]

https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/ex...
File src/com/google/caja/ses/explicit.html (right):

https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/ex...
src/com/google/caja/ses/explicit.html:171: ses.logger.info('Expected error to
test ses.getStack API: ', err);
I still don't understand what this is doing. How is this testing ses.getStack,
which is not used?

If this is about what I think it's about, stacks being lost when using the Caja
API, then that was due to the taming membrane — there's no reason to believe we
need to provide tools for investigating browsers' behavior (which is what
explicit.html is about, yes?) here.

https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/re...
File src/com/google/caja/ses/repairES5.js (right):

https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/re...
src/com/google/caja/ses/repairES5.js:2872: '(function() {\n' +
indent 2 more spaces (both outer and quoted code indent is wrong otherwise)

[MarkM, 2013-12-18 18:16:33]

Adds test for IE11 strict nested function defs scoping bug.
Adds stack display to explicit.html
Corrects some typos

[MarkM, 2013-12-18 18:18:11]

https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/ex...
File src/com/google/caja/ses/explicit.html (right):

https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/ex...
src/com/google/caja/ses/explicit.html:171: ses.logger.info('Expected error to
test ses.getStack API: ', err);
On 2013/12/18 18:03:32, kpreid2 wrote:
> I still don't understand what this is doing. How is this testing ses.getStack,
> which is not used?

The ses.logger installed by useHTMLLogger.js uses ses.getStack to display the
stack, if any, associated with the err argument.


> If this is about what I think it's about, stacks being lost when using the
Caja
> API, then that was due to the taming membrane — there's no reason to believe
we
> need to provide tools for investigating browsers' behavior (which is what
> explicit.html is about, yes?) here.

The issue is the non-membrane behavior of ses.getStack, which does indeed vary
between browsers, and which I want to start improving. For example, on Safari it
currently shows no stack when it could.

https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/re...
File src/com/google/caja/ses/repairES5.js (right):

https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/re...
src/com/google/caja/ses/repairES5.js:2872: '(function() {\n' +
On 2013/12/18 18:03:32, kpreid2 wrote:
> indent 2 more spaces (both outer and quoted code indent is wrong otherwise)

Done.

[kpreid2, 2013-12-18 18:25:56]

LGTM (given added comment as noted)

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explic...
File src/com/google/caja/ses/explicit.html (right):

https://codereview.appspot.com/43490045/diff/1/src/com/google/caja/ses/explic...
src/com/google/caja/ses/explicit.html:176: })();
On 2013/12/18 04:58:16, MarkM wrote:
> On 2013/12/18 04:28:03, kpreid2 wrote:
> > }());
> 
> Done. But why?

Because they should be consistent, and Crockford's opinion is that they should
be this way around, which is a good enough way to choose for me.

https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/ex...
File src/com/google/caja/ses/explicit.html (right):

https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/ex...
src/com/google/caja/ses/explicit.html:171: ses.logger.info('Expected error to
test ses.getStack API: ', err);
On 2013/12/18 18:18:12, MarkM wrote:
> The ses.logger installed by useHTMLLogger.js uses ses.getStack to display the
> stack, if any, associated with the err argument.
Please add that as a comment.

[MarkM, 2013-12-18 18:44:19]

Adds test for IE11 strict nested function defs scoping bug.
Adds stack display to explicit.html
Corrects some typos

[MarkM, 2013-12-18 18:46:00]

https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/ex...
File src/com/google/caja/ses/explicit.html (right):

https://codereview.appspot.com/43490045/diff/50001/src/com/google/caja/ses/ex...
src/com/google/caja/ses/explicit.html:171: ses.logger.info('Expected error to
test ses.getStack API: ', err);
On 2013/12/18 18:25:57, kpreid2 wrote:
> On 2013/12/18 18:18:12, MarkM wrote:
> > The ses.logger installed by useHTMLLogger.js uses ses.getStack to display
the
> > stack, if any, associated with the err argument.
> Please add that as a comment.

Done.