Issue 43470045: Add <canvas>.toDataURL().

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 43470045: Add <canvas>.toDataURL(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by kpreid2

Modified:
12 years, 2 months ago

Reviewers:
felix8a

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add <canvas>.toDataURL(). @r5646

Patch Set 1 #

Patch Set 2 : Add <canvas>.toDataURL(). #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -5 lines)			Patch
M	src/com/google/caja/plugin/domado.js	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	tests/com/google/caja/plugin/test-domado-canvas-guest.html	View		2 chunks	+44 lines, -5 lines	0 comments	Download
M	tests/com/google/caja/plugin/test-scan-guest.js	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

kpreid_google

On 2013/12/18 18:36:31, felix8a wrote: > lgtm Thanks. I'd been assigning these reviews to other ...

12 years, 2 months ago (2013-12-18 18:44:08 UTC) #3

felix8a

12 years, 2 months ago (2013-12-18 19:45:30 UTC) #5

On 2013/12/18 18:44:08, kpreid_google wrote:
> On 2013/12/18 18:36:31, felix8a wrote:
> > lgtm
> 
> Thanks. I'd been assigning these reviews to other people since I saw you were
on
> vacation.

yeah, cleaning out email in the downtime between family events, heh.

still lgtm

Expand All Messages | Collapse All Messages