Issue 4344061: Fix a crash during creating IBusProxy asynchronously

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4344061: Fix a crash during creating IBusProxy asynchronously (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by Peng

Modified:
14 years, 11 months ago

Reviewers:
Yusuke Sato

CC:
satorux

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Fix a crash during creating IBusProxy asynchronously BUG=chromium-os:13629 TEST=Linux desktop

Patch Set 1 #

Total comments: 4

Patch Set 2 : Update #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+210 lines, -19 lines)			Patch
M	src/ibusbus.c	View		2 chunks	+13 lines, -0 lines	0 comments	Download
M	src/ibusproxy.c	View		4 chunks	+84 lines, -19 lines	0 comments	Download
M	src/tests/.gitignore	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/tests/Makefile.am	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
A	src/tests/ibus-inputcontext-create.c	View	1	1 chunk	+108 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Yusuke Sato

LGTM. The change itself looks good to me but please check my comments below. http://codereview.appspot.com/4344061/diff/1/src/ibusbus.c ...

14 years, 11 months ago (2011-04-05 05:11:58 UTC) #2

Peng

14 years, 11 months ago (2011-04-05 14:08:35 UTC) #3

http://codereview.appspot.com/4344061/diff/1/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/4344061/diff/1/src/ibusbus.c#newcode564
src/ibusbus.c:564: * The connection is closed, can not contine next steps, so
complete
On 2011/04/05 05:11:58, Yusuke Sato wrote:
> Isn't it possible to add a test to src/tests/ for the "connection is closed"
> case?

I added two test cases, but seems it is difficult to test the connections closed
case.

http://codereview.appspot.com/4344061/diff/1/src/ibusproxy.c
File src/ibusproxy.c (right):

http://codereview.appspot.com/4344061/diff/1/src/ibusproxy.c#newcode164
src/ibusproxy.c:164: * When proxy is created asynchronously, the connection may
be closed
On 2011/04/05 05:11:58, Yusuke Sato wrote:
> ditto.

Done.

Expand All Messages | Collapse All Messages