Issue 4343053: DefaultIframeUriManager changes for handling locked domains (Closed)
DescriptionCurrently, specifying a lockedDomainSuffix with a port number causes an exception to be thrown when using the DefaultIframeUriManager and the DefaultUriParser. The problem is that such URLs are parsed as opaque and opaque URLs are not allowed by the default parser.
These changes will break unlockedDomain URLs such as "www.example.com" and "www.example.com:8080" when they used to work. These are now broken because I moved the setAuthority() call outside of the conditional in in DefaultIframeUriManager. Based on RFC 3986, a URI such as "www.example.com" is parsed as the Path not the Authority and one such as "www.example.com:8080" is parsed with "www.example.com" as the Scheme and "8080" as the Scheme-specific Part. The setAuthority() call in the case of a blank schema worked around that, although probably incorrectly. Unlocked domain URLs would now require either a Schema or "//" prepended to the URL in order to unambiguously be parsed as the Authority.
If this is going to cause too much turbulence, I could do some further checking as was done before.
Patch Set 1 #Patch Set 2 : Updates based on John's feedback #
Total comments: 1
Patch Set 3 : Fixed indentation inconsistencies #Patch Set 4 : Fixed indentation issues in the test file #
MessagesTotal messages: 8
|
||||||||||||||||||||||||||||
