Refactoring for dynamic JS compilation

- Convert logic in ExportJsCompiler to Processor.
- Reference to FeatureBundle instead of String.
- Avoid FeatureRegistry look-ups.

Follow-up: get rid of ExportJsCompiler.

[mhermanto, 2011-04-04 18:03:06]

Update for revert committed in r1088480

[johnfargo, 2011-04-04 22:13:21]

Looks like this CL's description was a little overstated. Which is fine -- this
is a good step function to the desc :)

http://codereview.appspot.com/4339045/diff/5005/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/SeparatorCommentingProcessor.java
(right):

http://codereview.appspot.com/4339045/diff/5005/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/SeparatorCommentingProcessor.java:44:
jsBuilder.add(newComment(lastFeature, false));
we might consider creating a sentinel "feature" represented by a static
FeatureBundle for text-created input. This Processor still wouldn't change -- it
would simply ensure that we can determine the size of text-added js.

http://codereview.appspot.com/4339045/diff/5005/java/gadgets/src/main/java/or...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/js/ExportJsCompiler.java
(right):

http://codereview.appspot.com/4339045/diff/5005/java/gadgets/src/main/java/or...
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/js/ExportJsCompiler.java:57:
public ExportJsCompiler(FeatureRegistry featureRegistry) {
not a problem per se, but I'd understood from the CL desc that the purpose here
is to turn the exports into a Processor rather than compiler?

[mhermanto, 2011-04-04 22:25:09]

On Mon, Apr 4, 2011 at 3:13 PM, <johnfargo@gmail.com> wrote:

> Looks like this CL's description was a little overstated. Which is fine
> -- this is a good step function to the desc :)
>
>
>
>
http://codereview.appspot.com/4339045/diff/5005/java/gadgets/src/main/java/or...
> File
>
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/SeparatorCommentingProcessor.java
> (right):
>
>
>
http://codereview.appspot.com/4339045/diff/5005/java/gadgets/src/main/java/or...
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/SeparatorCommentingProcessor.java:44:
> jsBuilder.add(newComment(lastFeature, false));
> we might consider creating a sentinel "feature" represented by a static
> FeatureBundle for text-created input. This Processor still wouldn't
> change -- it would simply ensure that we can determine the size of
> text-added js.
>

Yes.


>
>
>
http://codereview.appspot.com/4339045/diff/5005/java/gadgets/src/main/java/or...
> File
>
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/js/ExportJsCompiler.java
> (right):
>
>
>
http://codereview.appspot.com/4339045/diff/5005/java/gadgets/src/main/java/or...
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/js/ExportJsCompiler.java:57:
> public ExportJsCompiler(FeatureRegistry featureRegistry) {
> not a problem per se, but I'd understood from the CL desc that the
> purpose here is to turn the exports into a Processor rather than
> compiler?


http://codereview.appspot.com/4352049/ does this.

>
>
> http://codereview.appspot.com/4339045/
>