Issue 4331043: code review 4331043: debug/gosym: remove need for gotest to run preparatory ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4331043: code review 4331043: debug/gosym: remove need for gotest to run preparatory ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by r

Modified:
14 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

debug/gosym: remove need for gotest to run preparatory commands. Put them into the Makefile instead. One dependency mechanism is enough.

Patch Set 2 : diff -r 90b229dbdd2c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 90b229dbdd2c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 90b229dbdd2c https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 90b229dbdd2c https://go.googlecode.com/hg/ #

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	src/pkg/debug/gosym/Makefile	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	src/pkg/debug/gosym/pclntab_test.go	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 1 month ago (2011-03-29 17:29:22 UTC) #1

rsc

LGTM only rule rename applies to new revision http://codereview.appspot.com/4331043/diff/1/src/pkg/debug/gosym/Makefile File src/pkg/debug/gosym/Makefile (right): http://codereview.appspot.com/4331043/diff/1/src/pkg/debug/gosym/Makefile#newcode18 src/pkg/debug/gosym/Makefile:18: mkdir: ...

14 years, 1 month ago (2011-03-29 17:32:34 UTC) #2

14 years, 1 month ago (2011-03-29 17:41:27 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=95526b9291f4 ***

debug/gosym: remove need for gotest to run preparatory commands.
Put them into the Makefile instead. One dependency mechanism is enough.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4331043

Expand All Messages | Collapse All Messages