Issue 43260043: Hide Property Panel if engines have no properties.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 43260043: Hide Property Panel if engines have no properties. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by fujiwara

Modified:
10 years, 4 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Hide Property Panel if engines have no properties. If engines have no properites, Property Panel does not have to be shown. Also resize the topdevel window when engines are switched. TEST=ui/gtk3/ibus-ui-gtk3

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -4 lines)			Patch
		ui/gtk3/propertypanel.vala	View		5 chunks	+18 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

fujiwara

I forgot the ibus engines which have no properties. Tested Property Panel with some engines.

10 years, 4 months ago (2013-12-17 07:15:10 UTC) #1

Peng

10 years, 4 months ago (2013-12-17 22:39:51 UTC) #2

On 2013/12/17 07:15:10, fujiwara wrote:
> I forgot the ibus engines which have no properties.
> Tested Property Panel with some engines.

lgtm

Expand All Messages | Collapse All Messages