Issue 4317045: Patch to fix maven dependencies

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4317045: Patch to fix maven dependencies (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by Jasvir

Modified:
13 years, 9 months ago

Reviewers:
johnfargo, thorsten

CC:
shindig.remailer_gmail.com

Base URL:
https://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

* removes duplicate run dependencies

Patch Set 1 #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -17 lines)			Patch
	M	pom.xml	View		1 chunk	+0 lines, -17 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

thorsten_apache.org

14 years, 9 months ago (2011-03-28 08:20:40 UTC) #3

Can you please stop cross-posting?

salu2

On Fri, 2011-03-25 at 23:40 +0000, jasvir@gmail.com wrote:
> Reviewers: johnfargo,
> 
> Description:
> * removes duplicate run dependencies
> 
> 
> Please review this at http://codereview.appspot.com/4317045/
> 
> Affected files:
>    M     pom.xml
> 
> 
> Index: pom.xml
> ===================================================================
> --- pom.xml	(revision 1085592)
> +++ pom.xml	(working copy)
> @@ -505,23 +505,6 @@
>       <profile>
>         <id>run</id>
>         <dependencies>
> -        <dependency>
> -          <groupId>org.apache.shindig</groupId>
> -          <artifactId>shindig-gadgets</artifactId>
> -          <version>${project.version}</version>
> -        </dependency>
> -
> -        <dependency>
> -          <groupId>org.apache.shindig</groupId>
> -          <artifactId>shindig-social-api</artifactId>
> -          <version>${project.version}</version>
> -        </dependency>
> -
> -        <dependency>
> -          <groupId>org.apache.shindig</groupId>
> -          <artifactId>shindig-extras</artifactId>
> -          <version>${project.version}</version>
> -        </dependency>
>         </dependencies>
> 
>         <build>
> 
> 

-- 
Thorsten Scherler <thorsten.at.apache.org>
codeBusters S.L. - web based systems
<consulting, training and solutions>
http://www.codebusters.es/

Expand All Messages | Collapse All Messages