Issue 4317044: code review 4317044: testing: shorten some tests.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4317044: code review 4317044: testing: shorten some tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by r

Modified:
14 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

testing: shorten some tests. These are the top runners. More to come. Also print two digits of timing info under -test.v.

Patch Set 1 #

Patch Set 2 : diff -r 28208a3c82c6 https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -31 lines)			Patch
M	src/pkg/bytes/buffer_test.go	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	src/pkg/bytes/bytes_test.go	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/pkg/crypto/openpgp/s2k/s2k_test.go	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/crypto/rand/rand_test.go	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/pkg/crypto/rsa/pkcs1v15_test.go	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/pkg/crypto/rsa/rsa_test.go	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	src/pkg/sort/sort_test.go	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	src/pkg/strings/strings_test.go	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	src/pkg/sync/atomic/atomic_test.go	View	4 chunks	+12 lines, -10 lines	0 comments	Download
M	src/pkg/sync/rwmutex_test.go	View	1 chunk	+14 lines, -10 lines	0 comments	Download
M	src/pkg/testing/testing.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-03-25 22:21:14 UTC) #1

14 years ago (2011-03-25 23:31:17 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=da3b8ffd4832 ***

testing: shorten some tests.
These are the top runners.  More to come.
Also print two digits of timing info under -test.v.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4317044

Expand All Messages | Collapse All Messages