Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(312)

Issue 4313051: code review 4313051: build: add all-qemu.bash, handful of arm fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by rsc
Modified:
13 years, 7 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

build: add all-qemu.bash, handful of arm fixes

Patch Set 1 #

Patch Set 2 : diff -r 79c58fd0408a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 085423df5c7f https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 6b5fb88d1c2f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -11 lines) Patch
M doc/codelab/wiki/Makefile View 1 2 1 chunk +1 line, -1 line 0 comments Download
A src/all-qemu.bash View 1 1 chunk +16 lines, -0 lines 0 comments Download
M src/pkg/Makefile View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/go/printer/printer_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/linux/arm/signal.c View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/linux/signals.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/sync/atomic/asm_arm.s View 1 2 3 3 chunks +41 lines, -0 lines 0 comments Download
M src/pkg/sync/atomic/atomic_test.go View 1 7 chunks +32 lines, -1 line 0 comments Download
M src/pkg/sync/atomic/doc.go View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/run.bash View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/fixedbugs/bug243.go View 1 2 chunks +32 lines, -5 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 7 months ago (2011-03-27 21:19:03 UTC) #1
r
LGTM http://codereview.appspot.com/4313051/diff/4001/src/pkg/sync/atomic/asm_arm.s File src/pkg/sync/atomic/asm_arm.s (right): http://codereview.appspot.com/4313051/diff/4001/src/pkg/sync/atomic/asm_arm.s#newcode96 src/pkg/sync/atomic/asm_arm.s:96: // Second try. two tries still seems a ...
13 years, 7 months ago (2011-03-27 21:40:14 UTC) #2
rsc
13 years, 7 months ago (2011-03-28 03:39:43 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=3807b738e9ff ***

build: add all-qemu.bash, handful of arm fixes

R=r
CC=golang-dev
http://codereview.appspot.com/4313051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b