Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(176)

Issue 43060044: Fix logic in processSinglePathBinding (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by rafaelw
Modified:
12 years, 4 months ago
Reviewers:
arv
CC:
John Messerly, justin
Base URL:
https://github.com/Polymer/TemplateBinding.git@master
Visibility:
Public.

Description

Fix logic in processSinglePathBinding If the delegate returns an observer, it still must use the ObserverTransform if the binding is compound (has non-empty string tokens outside the mustache) R=arv BUG= Committed: https://github.com/Polymer/TemplateBinding/commit/11595a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
M src/TemplateBinding.js View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/tests.js View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 2
rafaelw
Committed patchset #1 manually as r11595a7 (presubmit successful).
12 years, 4 months ago (2013-12-17 01:50:38 UTC) #1
arv
12 years, 4 months ago (2013-12-17 15:30:17 UTC) #2
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b