Issue 43060044: Fix logic in processSinglePathBinding

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 43060044: Fix logic in processSinglePathBinding (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by rafaelw

Modified:
12 years, 4 months ago

Reviewers:
arv

CC:
John Messerly, justin

Base URL:
https://github.com/Polymer/TemplateBinding.git@master

Visibility:
Public.

More Reviews

Description

Fix logic in processSinglePathBinding If the delegate returns an observer, it still must use the ObserverTransform if the binding is compound (has non-empty string tokens outside the mustache) R=arv BUG= Committed: https://github.com/Polymer/TemplateBinding/commit/11595a7

Patch Set 1 #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -3 lines)			Patch
	M	src/TemplateBinding.js	View		1 chunk	+2 lines, -3 lines	0 comments	Download
	M	tests/tests.js	View		1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #1 manually as r11595a7 (presubmit successful).

12 years, 4 months ago (2013-12-17 01:50:38 UTC) #1

Message was sent while issue was closed.

LGTM

Expand All Messages | Collapse All Messages