Switch Shindig from cajita/valija to ES53

* upgrade the version of Caja
* switch from cajita/valija to ES53

This change does not support taming of features.

@ 1085619

[felix8a, 2011-03-22 07:48:24]

lgtm

http://codereview.appspot.com/4303043/diff/1/features/src/main/javascript/fea...
File features/src/main/javascript/features/caja/taming.js (right):

http://codereview.appspot.com/4303043/diff/1/features/src/main/javascript/fea...
features/src/main/javascript/features/caja/taming.js:105: imports =
imports.window;
it wasn't immediately obvious to me why imports and window are constructed in
this weird way.  but all this is going to be replaced soon-ish anyway, right?

[ihab.awad, 2011-03-22 17:49:54]

LGTM++

http://codereview.appspot.com/4303043/diff/1/features/src/main/javascript/fea...
File features/src/main/javascript/features/caja/taming.js (right):

http://codereview.appspot.com/4303043/diff/1/features/src/main/javascript/fea...
features/src/main/javascript/features/caja/taming.js:65:
___.markFunc(schema[0][schema[1]], schema[1]);
Use markTameAsFunction() not markFunc(). Throughout. But ok as-is given your
clarification that these are not yet being used and will be replaced wholesale
asap in favor of a caja.js-based solution.

[Jasvir, 2011-03-22 21:00:15]

Adding shindiv-dev.

On 2011/03/22 17:49:54, ihab.awad wrote:
> LGTM++
> 
>
http://codereview.appspot.com/4303043/diff/1/features/src/main/javascript/fea...
> File features/src/main/javascript/features/caja/taming.js (right):
> 
>
http://codereview.appspot.com/4303043/diff/1/features/src/main/javascript/fea...
> features/src/main/javascript/features/caja/taming.js:65:
> ___.markFunc(schema[0][schema[1]], schema[1]);
> Use markTameAsFunction() not markFunc(). Throughout. But ok as-is given your
> clarification that these are not yet being used and will be replaced wholesale
> asap in favor of a caja.js-based solution.

[Jasvir, 2011-03-22 21:01:55]

This CL is pending http://codereview.appspot.com/4274066/ that adds the missing
Array.forEach to Rhino for EndToEndTests.

[johnfargo, 2011-03-23 01:52:35]

http://codereview.appspot.com/4303043/diff/1/features/src/main/javascript/fea...
File features/src/main/javascript/features/caja/taming.js (right):

http://codereview.appspot.com/4303043/diff/1/features/src/main/javascript/fea...
features/src/main/javascript/features/caja/taming.js:100: imports.window =
imports.window || {};
all this JS will soon be subjected to Closure's property obfuscation. I assume
the key names here are important/should not be obfuscated. True? If so, I'd
recommend ['window'] et al.

[Jasvir, 2011-03-23 22:08:48]

snapshot

http://codereview.appspot.com/4303043/diff/1/features/src/main/javascript/fea...
File features/src/main/javascript/features/caja/taming.js (right):

http://codereview.appspot.com/4303043/diff/1/features/src/main/javascript/fea...
features/src/main/javascript/features/caja/taming.js:65:
___.markFunc(schema[0][schema[1]], schema[1]);
On 2011/03/22 17:49:54, ihab.awad wrote:
> Use markTameAsFunction() not markFunc(). Throughout. But ok as-is given your
> clarification that these are not yet being used and will be replaced wholesale
> asap in favor of a caja.js-based solution.

Done.

http://codereview.appspot.com/4303043/diff/1/features/src/main/javascript/fea...
features/src/main/javascript/features/caja/taming.js:100: imports.window =
imports.window || {};
On 2011/03/23 01:52:35, johnfargo wrote:
> all this JS will soon be subjected to Closure's property obfuscation. I assume
> the key names here are important/should not be obfuscated. True? If so, I'd
> recommend ['window'] et al.

Done.

http://codereview.appspot.com/4303043/diff/1/features/src/main/javascript/fea...
features/src/main/javascript/features/caja/taming.js:105: imports =
imports.window;
On 2011/03/22 07:48:24, felix8a wrote:
> it wasn't immediately obvious to me why imports and window are constructed in
> this weird way.  but all this is going to be replaced soon-ish anyway, right?

Done.

[johnfargo, 2011-03-23 23:29:58]

one missed ref.

LGTM otherwise.

http://codereview.appspot.com/4303043/diff/1010/features/src/main/javascript/...
File features/src/main/javascript/features/caja/taming.js (right):

http://codereview.appspot.com/4303043/diff/1010/features/src/main/javascript/...
features/src/main/javascript/features/caja/taming.js:103: imports.window[i] =
imports[i];
imports['window']

[Jasvir, 2011-03-25 18:47:43]

Bumped version to include Array.forEach missing from rhino and used by EndToEnd
tests.

http://codereview.appspot.com/4303043/diff/1010/features/src/main/javascript/...
File features/src/main/javascript/features/caja/taming.js (right):

http://codereview.appspot.com/4303043/diff/1010/features/src/main/javascript/...
features/src/main/javascript/features/caja/taming.js:103: imports.window[i] =
imports[i];
On 2011/03/23 23:29:58, johnfargo wrote:
> imports['window']

Done.

[johnfargo, 2011-03-25 19:13:27]

LGTM++

Long live 5/3

On 2011/03/25 18:47:43, jasvir wrote:
> Bumped version to include Array.forEach missing from rhino and used by
EndToEnd
> tests.
> 
>
http://codereview.appspot.com/4303043/diff/1010/features/src/main/javascript/...
> File features/src/main/javascript/features/caja/taming.js (right):
> 
>
http://codereview.appspot.com/4303043/diff/1010/features/src/main/javascript/...
> features/src/main/javascript/features/caja/taming.js:103: imports.window[i] =
> imports[i];
> On 2011/03/23 23:29:58, johnfargo wrote:
> > imports['window']
> 
> Done.