Copy gadget and container in CacheEnforcementVisitor

Copy gadget and container of the original request in CacheEnforcementVisitor while triggering fetches.

[atulvasu, 2011-03-15 10:31:05]

LGTM

[gagan.goku, 2011-03-15 10:40:37]

Looks good.

http://codereview.appspot.com/4295051/diff/11001/java/gadgets/src/main/java/o...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java
(right):

http://codereview.appspot.com/4295051/diff/11001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java:89:
request.setGadget(spec.getUrl());
this conflicts with
http://codereview.appspot.com/4277050/diff/1/java/gadgets/src/main/java/org/a...
which 1 should i look at first ?

[gagan.goku, 2011-03-15 10:43:06]

http://codereview.appspot.com/4295051/diff/11001/java/gadgets/src/main/java/o...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java
(right):

http://codereview.appspot.com/4295051/diff/11001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java:84:
protected static HttpRequest createNewHttpRequest(Gadget gadget, String uriStr)
{
make this non static so subclasses can override.

[nikhilmadan23, 2011-03-15 10:43:17]

http://codereview.appspot.com/4295051/diff/11001/java/gadgets/src/main/java/o...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java
(right):

http://codereview.appspot.com/4295051/diff/11001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java:89:
request.setGadget(spec.getUrl());
On 2011/03/15 10:40:37, gagan.goku wrote:
> this conflicts with
>
http://codereview.appspot.com/4277050/diff/1/java/gadgets/src/main/java/org/a...
> which 1 should i look at first ?

Please ignore that patch. I've patched it in here.

[atulvasu, 2011-03-15 10:43:27]

I'll revert my CL he does all that I needed :)

On Tue, Mar 15, 2011 at 4:10 PM, <gagan.goku@gmail.com> wrote:

> Looks good.
>
>
>
>
http://codereview.appspot.com/4295051/diff/11001/java/gadgets/src/main/java/o...
> File
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java
> (right):
>
>
>
http://codereview.appspot.com/4295051/diff/11001/java/gadgets/src/main/java/o...
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java:89:
> request.setGadget(spec.getUrl());
> this conflicts with
>
>
http://codereview.appspot.com/4277050/diff/1/java/gadgets/src/main/java/org/a...
> which 1 should i look at first ?
>
>
> http://codereview.appspot.com/4295051/
>

[nikhilmadan23, 2011-03-15 10:52:04]

Addressing comments

[nikhilmadan23, 2011-03-15 10:52:22]

http://codereview.appspot.com/4295051/diff/11001/java/gadgets/src/main/java/o...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java
(right):

http://codereview.appspot.com/4295051/diff/11001/java/gadgets/src/main/java/o...
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java:84:
protected static HttpRequest createNewHttpRequest(Gadget gadget, String uriStr)
{
On 2011/03/15 10:43:06, gagan.goku wrote:
> make this non static so subclasses can override.

Done.

[gagan.goku, 2011-03-15 12:57:38]

Build looks good.
Committed as r1081754.