src/pkg/http/cgi/testdata/test.cgi - Issue 4291069: code review 4291069: http: modified perl cgi test to remove newline from env...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/pkg/http/cgi/testdata/test.cgi

Issue 4291069: code review 4291069: http: modified perl cgi test to remove newline from env...

Left Patch Set: diff -r fad73d342108 https://go.googlecode.com/hg/ Created 13 years, 11 months ago

Right Patch Set: diff -r fad73d342108 https://go.googlecode.com/hg/ Created 13 years, 11 months ago

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #!/usr/bin/perl	1 #!/usr/bin/perl

2 # Copyright 2011 The Go Authors. All rights reserved.	2 # Copyright 2011 The Go Authors. All rights reserved.

3 # Use of this source code is governed by a BSD-style	3 # Use of this source code is governed by a BSD-style

4 # license that can be found in the LICENSE file.	4 # license that can be found in the LICENSE file.

5 #	5 #

6 # Test script run as a child process under cgi_test.go	6 # Test script run as a child process under cgi_test.go

7	7

8 use strict;	8 use strict;

9 use CGI;	9 use CGI;

10	10

(...skipping 13 matching lines...) Expand all Loading...
24 $p->("");	24 $p->("");

25	25

26 print "test=Hello CGI\n";	26 print "test=Hello CGI\n";

27	27

28 foreach my $k (sort keys %$params) {	28 foreach my $k (sort keys %$params) {

29 print "param-$k=$params->{$k}\n";	29 print "param-$k=$params->{$k}\n";

30 }	30 }

31	31

32 foreach my $k (sort keys %ENV) {	32 foreach my $k (sort keys %ENV) {

33 my $clean_env = $ENV{$k};	33 my $clean_env = $ENV{$k};

34 » $clean_env =~ s/[\n\r]//g;	34 $clean_env =~ s/[\n\r]//g;

35 » print "env-$k=$clean_env\n";	35 print "env-$k=$clean_env\n";

36 }	36 }

LEFT	RIGHT