Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(44)

Issue 4287056: code review 4287056: Make.pkg: add support for SWIG, and add two SWIG examples (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by iant
Modified:
13 years, 4 months ago
Reviewers:
CC:
r, rsc, iant2, golang-dev
Visibility:
Public.

Description

Make.pkg: add support for SWIG, and add two SWIG examples The SWIG examples are not yet built or tested by default.

Patch Set 1 #

Patch Set 2 : diff -r 82be792fafa3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 82be792fafa3 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 4 : diff -r ab74b6da1721 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 9add7892ac1d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -8 lines) Patch
A misc/swig/callback/Makefile View 1 1 chunk +17 lines, -0 lines 0 comments Download
A misc/swig/callback/callback.h View 1 1 chunk +24 lines, -0 lines 0 comments Download
A misc/swig/callback/callback.swigcxx View 1 1 chunk +18 lines, -0 lines 0 comments Download
A misc/swig/callback/run View 1 2 3 Binary file 0 comments Download
A misc/swig/callback/run.go View 1 2 3 1 chunk +39 lines, -0 lines 0 comments Download
A misc/swig/stdio/Makefile View 1 1 chunk +17 lines, -0 lines 0 comments Download
A misc/swig/stdio/file.swig View 1 1 chunk +11 lines, -0 lines 0 comments Download
A misc/swig/stdio/hello View 1 2 3 Binary file 0 comments Download
A misc/swig/stdio/hello.go View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/Make.pkg View 1 2 3 4 chunks +66 lines, -8 lines 0 comments Download

Messages

Total messages: 8
iant
Hello r, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2011-03-17 02:56:24 UTC) #1
rsc
LGTM http://codereview.appspot.com/4287056/diff/4001/misc/swig/callback/run.go File misc/swig/callback/run.go (right): http://codereview.appspot.com/4287056/diff/4001/misc/swig/callback/run.go#newcode8 misc/swig/callback/run.go:8: "swig/callback" sort http://codereview.appspot.com/4287056/diff/4001/src/Make.pkg File src/Make.pkg (right): http://codereview.appspot.com/4287056/diff/4001/src/Make.pkg#newcode48 src/Make.pkg:48: ...
13 years, 4 months ago (2011-03-17 05:26:32 UTC) #2
iant2
rsc@golang.org writes: > http://codereview.appspot.com/4287056/diff/4001/src/Make.pkg#newcode48 > src/Make.pkg:48: INSTALLFILES+=$(patsubst > %.swig,$(pkgdir)/$(dir)/%.so,$(patsubst %.swigcxx,%.swig,$(SWIGFILES))) > What do we need ...
13 years, 4 months ago (2011-03-17 15:52:20 UTC) #3
rsc
> Unless I misunderstand I think we're OK. We put a simple name, not a ...
13 years, 4 months ago (2011-03-17 16:11:45 UTC) #4
r
LGTM
13 years, 4 months ago (2011-03-18 00:22:34 UTC) #5
iant2
Russ Cox <rsc@golang.org> writes: >> Unless I misunderstand I think we're OK. We put a ...
13 years, 4 months ago (2011-03-21 21:16:31 UTC) #6
rsc
LGTM
13 years, 4 months ago (2011-03-22 18:32:51 UTC) #7
iant
13 years, 4 months ago (2011-03-22 20:06:03 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=53d99c6f0ef8 ***

Make.pkg: add support for SWIG, and add two SWIG examples

The SWIG examples are not yet built or tested by default.

R=r, rsc, iant2
CC=golang-dev
http://codereview.appspot.com/4287056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b