Set party lang as a configuration option

[ced, 2011-03-15 16:08:55]

http://codereview.appspot.com/4287051/diff/1/configuration.py
File configuration.py (right):

http://codereview.appspot.com/4287051/diff/1/configuration.py#newcode17
configuration.py:17: party_lang = fields.Property(fields.Many2One("ir.lang",
'Party Language'))
Perhaps a small help='Default Party Language'

http://codereview.appspot.com/4287051/diff/1/party.py
File party.py (right):

http://codereview.appspot.com/4287051/diff/1/party.py#newcode93
party.py:93: return config.party_lang.id
Test is party_lang is set before using id

[yangoon, 2011-03-15 22:00:38]

http://codereview.appspot.com/4287051/diff/1/configuration.py
File configuration.py (right):

http://codereview.appspot.com/4287051/diff/1/configuration.py#newcode17
configuration.py:17: party_lang = fields.Property(fields.Many2One("ir.lang",
'Party Language'))
On 2011/03/15 16:08:55, ced wrote:
> Perhaps a small help='Default Party Language'

Better name the the field name like that. help could even be more explicit: 'The
value set on this field  will preset the language on new parties.'

[nicoe, 2011-03-16 11:59:41]

http://codereview.appspot.com/4287051/diff/1/configuration.py
File configuration.py (right):

http://codereview.appspot.com/4287051/diff/1/configuration.py#newcode17
configuration.py:17: party_lang = fields.Property(fields.Many2One("ir.lang",
'Party Language'))
On 2011/03/15 22:00:39, yangoon wrote:
> On 2011/03/15 16:08:55, ced wrote:
> > Perhaps a small help='Default Party Language'
> 
> Better name the the field name like that. help could even be more explicit:
'The
> value set on this field  will preset the language on new parties.'

I will use your help text. But field name is <object>_<fieldname> just like the
others.

[ced, 2011-03-25 10:13:31]

http://codereview.appspot.com/4287051/diff/8001/party.py
File party.py (right):

http://codereview.appspot.com/4287051/diff/8001/party.py#newcode93
party.py:93: return config.party_lang.id
Does it work if there is no lang define on config?

http://codereview.appspot.com/4287051/diff/8001/party.py#newcode184
party.py:184: ids = self.search([('code',) + clause[1:]], order=[])
Remove trailling space in separate patch

[nicoe, 2011-03-29 09:17:10]

http://codereview.appspot.com/4287051/diff/8001/party.py
File party.py (right):

http://codereview.appspot.com/4287051/diff/8001/party.py#newcode93
party.py:93: return config.party_lang.id
On 2011/03/25 10:13:31, ced wrote:
> Does it work if there is no lang define on config?

Yes it does not select anything then.

http://codereview.appspot.com/4287051/diff/8001/party.py#newcode184
party.py:184: ids = self.search([('code',) + clause[1:]], order=[])
On 2011/03/25 10:13:31, ced wrote:
> Remove trailling space in separate patch

Done.

[ced, 2011-03-29 13:03:00]

LGTM