Issue 4286049: Autocompletion on char fields (client patch)

Issue 4286049: Autocompletion on char fields (client patch) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by nicoe

Modified:
14 years, 10 months ago

Reviewers:
ced

Visibility:
Public.

Patch Set 2 : Display autocompletion as ComboboxEntry #

Patch Set 3 : remove gtk warning #

Total comments: 11

Patch Set 4 : ACK cedric's remarks #

Total comments: 1

Patch Set 5 : Add missing 'or False' #

Total comments: 4

Patch Set 6 : Always get value from entry widgets #

Patch Set 7 : removed completion support in m2o #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -45 lines)			Patch
M	tryton/gui/window/view_form/model/field.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tryton/gui/window/view_form/model/record.py	View	1 2 3	3 chunks	+29 lines, -0 lines	0 comments	Download
M	tryton/gui/window/view_form/view/form_gtk/char.py	View	1 2 3 4 5	3 chunks	+53 lines, -11 lines	0 comments	Download
M	tryton/gui/window/view_form/view/form_gtk/many2one.py	View	1 2 3 4 5 6	1 chunk	+0 lines, -33 lines	0 comments	Download
M	tryton/gui/window/view_form/view/form_gtk/parser.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 14

Expand All Messages | Collapse All Messages

ced

http://codereview.appspot.com/4286049/diff/1005/tryton/gui/window/view_form/model/record.py File tryton/gui/window/view_form/model/record.py (right): http://codereview.appspot.com/4286049/diff/1005/tryton/gui/window/view_form/model/record.py#newcode466 tryton/gui/window/view_form/model/record.py:466: return I think you should clean autocompletion for this ...

14 years, 11 months ago (2011-03-15 11:31:44 UTC) #4

nicoe

14 years, 11 months ago (2011-03-18 16:39:48 UTC) #5

ced

http://codereview.appspot.com/4286049/diff/8003/tryton/gui/window/view_form/view/form_gtk/char.py File tryton/gui/window/view_form/view/form_gtk/char.py (right): http://codereview.appspot.com/4286049/diff/8003/tryton/gui/window/view_form/view/form_gtk/char.py#newcode48 tryton/gui/window/view_form/view/form_gtk/char.py:48: value = self.entry.get_child().get_text() Still missing: ...or False

14 years, 11 months ago (2011-03-18 17:38:01 UTC) #7

ced

http://codereview.appspot.com/4286049/diff/16001/tryton/gui/window/view_form/view/form_gtk/char.py File tryton/gui/window/view_form/view/form_gtk/char.py (right): http://codereview.appspot.com/4286049/diff/16001/tryton/gui/window/view_form/view/form_gtk/char.py#newcode48 tryton/gui/window/view_form/view/form_gtk/char.py:48: value = self.entry.get_child().get_text() or False Why not always take ...

14 years, 11 months ago (2011-03-25 10:27:17 UTC) #9

nicoe

14 years, 10 months ago (2011-03-29 09:37:49 UTC) #10

LGTM

Expand All Messages | Collapse All Messages