Separate logic to get converter for REST response and request in DataServiceServlet

This patch is related to JIRA bug (SHINDIG-1515) Why shindig uses "Content-Type" not "Accept" to determine the return info type.

Currently the REST servlet, DataServiceServlet, uses the same converted to process request payload to also process the response content-type and body.

This CR contains changes to separate the logic to get the BeanConverter for request and response, and also fix to the unit test cases.

For response, it will simply check the "format" request parameter and defaulted to JSON if not specified as defined in the OpenSocial Core Server API spec 1.1.

We could add logic to check Accept header for response if needed.

[henry.saputra, 2011-03-19 02:32:41]

Proposed fix to separate logic to get converter for REST response and request in
DataServiceServlet.

[Paul Lindner, 2011-03-23 15:40:04]

LGTM

http://codereview.appspot.com/4282058/diff/6002/java/common/src/main/java/org...
File
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java
(right):

http://codereview.appspot.com/4282058/diff/6002/java/common/src/main/java/org...
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java:171:
contentType = ContentTypes.extractMimePart(servletRequest.getContentType());
remove commented code?

http://codereview.appspot.com/4282058/diff/6002/java/common/src/main/java/org...
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java:238:
BeanConverter getConverterForRequest(String contentType, String format) {
add @Nullable if contentType can be null (which I believe it can be)

http://codereview.appspot.com/4282058/diff/6002/java/common/src/main/java/org...
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java:275:
if (ATOM_FORMAT.equals(format)) {
this (and the logic above) can be represented as a ternary 
 return ATOM_FORMAT.equals(format) ? atomConverter :
            XML_FORMAT.equals(format) ? xmlConverter :
                jsonConverter ;

[henry.saputra, 2011-03-24 07:05:28]

Thanks for the review Paul. Checked in as rev 1084860

http://codereview.appspot.com/4282058/diff/6002/java/common/src/main/java/org...
File
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java
(right):

http://codereview.appspot.com/4282058/diff/6002/java/common/src/main/java/org...
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java:171:
contentType = ContentTypes.extractMimePart(servletRequest.getContentType());
Thanks, will do.

On 2011/03/23 15:40:05, Paul Lindner wrote:
> remove commented code?

http://codereview.appspot.com/4282058/diff/6002/java/common/src/main/java/org...
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java:238:
BeanConverter getConverterForRequest(String contentType, String format) {
Done.

On 2011/03/23 15:40:05, Paul Lindner wrote:
> add @Nullable if contentType can be null (which I believe it can be)

http://codereview.appspot.com/4282058/diff/6002/java/common/src/main/java/org...
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServlet.java:275:
if (ATOM_FORMAT.equals(format)) {
Done, thanks for the input.

On 2011/03/23 15:40:05, Paul Lindner wrote:
> this (and the logic above) can be represented as a ternary 
>  return ATOM_FORMAT.equals(format) ? atomConverter :
>             XML_FORMAT.equals(format) ? xmlConverter :
>                 jsonConverter ;