Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(965)

Issue 4281051: Rewrite of peephole to work on AST

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by Eugene Toder
Modified:
1 year, 11 months ago
Reviewers:
Nick Coghlan
Base URL:
http://hg.python.org/cpython/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Update #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2397 lines, -814 lines) Patch
M Include/Python-ast.h View 7 chunks +18 lines, -30 lines 0 comments Download
M Include/compile.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Lib/ast.py View 5 chunks +10 lines, -14 lines 0 comments Download
A Lib/test/disutil.py View 1 chunk +19 lines, -0 lines 0 comments Download
M Lib/test/test_ast.py View 6 chunks +58 lines, -56 lines 0 comments Download
M Lib/test/test_compile.py View 1 2 chunks +44 lines, -0 lines 0 comments Download
M Lib/test/test_peepholer.py View 1 9 chunks +125 lines, -33 lines 0 comments Download
M Lib/test/test_sys_settrace.py View 1 chunk +3 lines, -3 lines 0 comments Download
M Makefile.pre.in View 3 chunks +7 lines, -0 lines 0 comments Download
M PC/os2emx/python33.def View 1 chunk +1 line, -3 lines 0 comments Download
M Parser/Python.asdl View 3 chunks +6 lines, -8 lines 0 comments Download
M Parser/asdl_c.py View 2 chunks +16 lines, -8 lines 0 comments Download
A Parser/asdl_ct.py View 1 1 chunk +260 lines, -0 lines 0 comments Download
M Python/Python-ast.c View 76 chunks +622 lines, -521 lines 0 comments Download
M Python/ast.c View 16 chunks +91 lines, -24 lines 0 comments Download
A Python/ast_opt.c View 1 1 chunk +544 lines, -0 lines 0 comments Download
A Python/ast_opt.ct View 1 1 chunk +265 lines, -0 lines 0 comments Download
M Python/compile.c View 1 28 chunks +301 lines, -103 lines 1 comment Download
M Python/future.c View 2 chunks +3 lines, -7 lines 0 comments Download
M Python/symtable.c View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 1
Nick Coghlan
6 years, 7 months ago (2011-03-27 11:26:13 UTC) #1
Minor comments to supplement the more general ones on the tracker item.

http://codereview.appspot.com/4281051/diff/2001/Python/compile.c
File Python/compile.c (right):

http://codereview.appspot.com/4281051/diff/2001/Python/compile.c#newcode3185
Python/compile.c:3185: return e->kind == Lit_kind ? PyObject_IsTrue(e->v.Lit.v)
: -1;
This loses the __debug__ special casing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4