Issue 4281042: Use selection widget for subdivision field

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4281042: Use selection widget for subdivision field (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by nicoe

Modified:
14 years, 10 months ago

Reviewers:
ced

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix returns of vals and indentation #

Total comments: 1

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	address.py	View	1	2 chunks	+11 lines, -1 line	0 comments	Download
	M	address.xml	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ced

Must be split into 2 patches. One with the on_change fix that will be back-ported ...

14 years, 11 months ago (2011-03-12 17:21:42 UTC) #2

ced

14 years, 10 months ago (2011-03-29 13:12:40 UTC) #3

http://codereview.appspot.com/4281042/diff/2002/address.xml
File address.xml (right):

http://codereview.appspot.com/4281042/diff/2002/address.xml#newcode53
address.xml:53: <field name="country" completion="1"/>
Change both into widget="selection" or any

Expand All Messages | Collapse All Messages