Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 4280065: syscall: StartProcess Chroot and Credential. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by albert.strasheim
Modified:
9 years, 10 months ago
Reviewers:
CC:
rsc, iant, agl1, golang-dev
Visibility:
Public.

Description

syscall: StartProcess Chroot and Credential.

Patch Set 1 #

Patch Set 2 : diff -r 44e733716d02 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 3 : diff -r 44e733716d02 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3807b738e9ff https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -7 lines) Patch
M src/pkg/syscall/exec_unix.go View 1 2 3 5 chunks +47 lines, -7 lines 0 comments Download

Messages

Total messages: 14
albert.strasheim
Hello all Please review this change. I used the following test with Busybox installed in ...
9 years, 10 months ago (2011-03-24 12:19:09 UTC) #1
agl1
http://codereview.appspot.com/4280065/diff/1002/src/pkg/syscall/exec_unix.go File src/pkg/syscall/exec_unix.go (right): http://codereview.appspot.com/4280065/diff/1002/src/pkg/syscall/exec_unix.go#newcode160 src/pkg/syscall/exec_unix.go:160: _, _, err1 = RawSyscall(SYS_SETGID, uintptr(attr.Credentials.Groups[0]), 0, 0) The ...
9 years, 10 months ago (2011-03-24 13:56:28 UTC) #2
albert.strasheim
Hello On Thu, Mar 24, 2011 at 3:56 PM, <agl@golang.org> wrote: > > http://codereview.appspot.com/4280065/diff/1002/src/pkg/syscall/exec_unix.go > ...
9 years, 10 months ago (2011-03-24 14:02:03 UTC) #3
agl1
On Thu, Mar 24, 2011 at 10:01 AM, Albert Strasheim <fullung@gmail.com> wrote: > By clear ...
9 years, 10 months ago (2011-03-24 14:05:45 UTC) #4
albert.strasheim
PTAL On 2011/03/24 13:56:28, agl1 wrote: > http://codereview.appspot.com/4280065/diff/1002/src/pkg/syscall/exec_unix.go > File src/pkg/syscall/exec_unix.go (right): > > http://codereview.appspot.com/4280065/diff/1002/src/pkg/syscall/exec_unix.go#newcode160 ...
9 years, 10 months ago (2011-03-24 15:09:29 UTC) #5
rsc
s/Credentials/Credential/ i'd prefer a better name but none come to mind. i think you need ...
9 years, 10 months ago (2011-03-24 22:58:08 UTC) #6
albert.strasheim
Hello On Fri, Mar 25, 2011 at 12:58 AM, Russ Cox <rsc@golang.org> wrote: > s/Credentials/Credential/ ...
9 years, 10 months ago (2011-03-25 05:04:00 UTC) #7
rsc
Please change to Credential. It is a single identity even if it has multiple pieces. ...
9 years, 10 months ago (2011-03-25 18:38:36 UTC) #8
albert.strasheim
Hello On Fri, Mar 25, 2011 at 8:38 PM, Russ Cox <rsc@golang.org> wrote: > Please ...
9 years, 10 months ago (2011-03-25 20:57:39 UTC) #9
rsc
> Maybe it should simply be an error to not specify at least one group. ...
9 years, 10 months ago (2011-03-25 21:17:25 UTC) #10
albert.strasheim
PTAL. On 2011/03/25 21:17:25, rsc wrote: > > Maybe it should simply be an error ...
9 years, 10 months ago (2011-03-28 05:33:14 UTC) #11
agl1
LGTM. Will land if nobody else comments today.
9 years, 10 months ago (2011-03-29 14:54:30 UTC) #12
rsc
LGTM
9 years, 10 months ago (2011-03-29 18:09:31 UTC) #13
agl1
9 years, 10 months ago (2011-03-29 18:29:30 UTC) #14
*** Submitted as http://code.google.com/p/go/source/detail?r=a25343ee3016 ***

syscall: StartProcess Chroot and Credential.

R=rsc, iant, agl1
CC=golang-dev
http://codereview.appspot.com/4280065

Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b