Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(189)

Issue 4280051: Avoid wrapping each feature in anon function (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by mhermanto
Modified:
15 years ago
Reviewers:
johnfargo, fargo
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Each function avoids compiler from doing aggressive compilation of symbols across features.

Patch Set 1 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/js/ExportJsCompiler.java View 2 chunks +1 line, -2 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/js/ExportJsCompilerTest.java View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2
mhermanto
15 years ago (2011-03-15 20:25:58 UTC) #1
johnfargo
15 years ago (2011-03-15 20:34:50 UTC) #2
LGTM

On 2011/03/15 20:25:58, mhermanto wrote:
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b